Skip to content

Remove null values from cache to improve Onyx read speed #553

Closed

Description

@chrispader

In #411 we changed code in Onyx to persist null values in cache, in order for the user to know, that a value has been accessed before but there's no value.

This fixed an issue here but apperantly isn't the perfect solution, since it requires us to remove null values on read, as implemented in #519.

This PR removes null values from cache and removes calls to removeNestedNullValues on read. Instead, null values are only going to be removed on write (e.g. Onyx.merge/Onyx.set).

This should speed up read speeds by a lot, since it prevents the problem described in https://expensify.slack.com/archives/C05LX9D6E07/p1716395008375049?thread_ts=1716303470.244179&cid=C05LX9D6E07

Activity

  1. kevinksullivan commented on Jun 4, 2024

    @kevinksullivan
  2. moved this from CRITICAL to LOW in [#whatsnext] #qualityon Jun 4, 2024
  3. chrispader commented on Jun 5, 2024

    @chrispader
    ContributorAuthor
  4. muttmuure commented on Jul 31, 2024

    @muttmuure

    This can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions