You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Remove null values from cache to improve Onyx read speed #553
In #411 we changed code in Onyx to persist null values in cache, in order for the user to know, that a value has been accessed before but there's no value.
This fixed an issue here but apperantly isn't the perfect solution, since it requires us to remove null values on read, as implemented in #519.
This PR removes null values from cache and removes calls to removeNestedNullValues on read. Instead, null values are only going to be removed on write (e.g. Onyx.merge/Onyx.set).
Activity
kevinksullivan commentedon Jun 4, 2024
asked for status update on this here
https://expensify.slack.com/archives/C05LX9D6E07/p1717540938581599
chrispader commentedon Jun 5, 2024
As described by @mountiny in https://expensify.slack.com/archives/C05LX9D6E07/p1717542026961829?thread_ts=1717540938.581599&cid=C05LX9D6E07, working on shipping this in the current Onyx bump PR
muttmuure commentedon Jul 31, 2024
This can be closed