Repository navigation
Remove obsolete compiler flags before TypeScript 7 - #138
Draft
roryabraham wants to merge 1 commit into
Draft
roryabraham wants to merge 1 commit into
roryabraham wants to merge 1 commit into
Conversation
JakubKorytko
approved these changes
Nov 9, 2026
JakubKorytko
left a comment
Member
There was a problem hiding this comment.
LGTM. Both flags were set to their default (false), so removing them is a no-op
Member
|
not merging tho since it is still in draft |
Contributor
Author
|
Yeah once TS 7.1 becomes stable for 1 week I'll upgrade and open this for review. Upgrading across the whole org |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Remove two disabled compiler options that TypeScript 7 no longer accepts. This is preparation only; the beta upgrade still needs a resolver migration and compatible lint tooling.
AI checks: root and both workspace typechecks, root lint, and library/plugin builds passed. Checked files and declaration output are unchanged.
Related Issues
For https://github.com/Expensify/Expensify/issues/701267
Manual Tests
lib/typescript/src/index.d.ts.No new tests are needed for removing disabled options. Native QA was not run.
Linked PRs
None.