Skip to content

Remove obsolete compiler flags before TypeScript 7 - #138

Draft
roryabraham wants to merge 1 commit into
mainfrom
rory-ts71-beta
Draft

roryabraham wants to merge 1 commit into
mainfrom
rory-ts71-beta

Conversation

@roryabraham

Copy link
Copy Markdown
Contributor

Details

Remove two disabled compiler options that TypeScript 7 no longer accepts. This is preparation only; the beta upgrade still needs a resolver migration and compatible lint tooling.

AI checks: root and both workspace typechecks, root lint, and library/plugin builds passed. Checked files and declaration output are unchanged.

Related Issues

For https://github.com/Expensify/Expensify/issues/701267

Manual Tests

  1. Run the existing typechecks, root lint, and library/plugin builds.
  2. Confirm declarations still resolve at lib/typescript/src/index.d.ts.

No new tests are needed for removing disabled options. Native QA was not run.

Linked PRs

None.

@roryabraham roryabraham self-assigned this Nov 7, 2026

@JakubKorytko JakubKorytko left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Both flags were set to their default (false), so removing them is a no-op

@JakubKorytko

Copy link
Copy Markdown
Member

not merging tho since it is still in draft

@roryabraham

Copy link
Copy Markdown
Contributor Author

Yeah once TS 7.1 becomes stable for 1 week I'll upgrade and open this for review. Upgrading across the whole org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants