Repository navigation
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Closes #592.
When a readiness probe stops a child, that child can exit and be replaced before the stop timeout expires. The timeout was waiting for the whole restart loop and reading the current command at the end, so it could send SIGKILL to the replacement.
Bind each stop to the original command and its completion channel. A regression sends the same internal stop used by the readiness probe, then checks that the wait finishes promptly and the restarted child stays running. Before the fix, the old stop timed out and killed the replacement.
go test ./...passed on macOS arm64. The focused stop and readiness regressions passed three runs under the race detector. The fullmake testracefound a race in watcher setup and teardown inTestWatch_ExitOnEndSurvivesRestart; the same race reproduced on unchanged main at190d026.