Skip to content

close #102 - #142

Merged
nmschulte merged 7 commits into
FOME-Tech:masterfrom
mi-hol:sidebar_order
Sep 4, 2023
Merged

nmschulte merged 7 commits into
FOME-Tech:masterfrom
mi-hol:sidebar_order

Conversation

@mi-hol

@mi-hol mi-hol commented Sep 2, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@mi-hol

mi-hol commented Sep 2, 2023 •

Copy link
Copy Markdown
Contributor Author

@karniv00l may I ask for your help please?

GHA validate fails but local test succeeds, what could be the root cause?

 npm start

> wiki@0.0.0 start
> docusaurus start --host 0.0.0.0

[INFO] Starting the development server...
[SUCCESS] Docusaurus website is running at: http://localhost:3000/

✔ Client
  Compiled successfully in 20.06s

client (webpack 5.85.0) compiled successfully

@karniv00l

karniv00l commented Sep 3, 2023 •

Copy link
Copy Markdown
Member

Run

npm run build

to see build errors locally

@mi-hol
mi-hol marked this pull request as draft September 3, 2023 14:40
@nmschulte

nmschulte commented Sep 3, 2023 •

Copy link
Copy Markdown
Contributor

to see build errors locally

I receive these warnings from both the start and build npm scripts:

[WARNING] Docs markdown link couldn't be resolved: (/Advanced-Features/ETB/ETB-PID.md) in ".../wiki/docs/02-Intro-Start-Here/10-HT-PID-ETB-And-VVT.md" for version current
[WARNING] Docs markdown link couldn't be resolved: (/Advanced-Features/Variable-Cam-Timing/VVT-PID.md) in ".../wiki/docs/02-Intro-Start-Here/10-HT-PID-ETB-And-VVT.md" for version current

And I receive these errors from the build script:

Exhaustive list of all broken links found:

- On source page path = /Intro-Start-Here/HT-PID-ETB-And-VVT/:
   -> linking to /Advanced-Features/ETB/ETB-PID.md/
   -> linking to /Advanced-Features/Variable-Cam-Timing/VVT-PID.md/

@mi-hol
mi-hol marked this pull request as ready for review September 3, 2023 18:00
@mi-hol

mi-hol commented Sep 3, 2023

Copy link
Copy Markdown
Contributor Author

fix #102

@mi-hol

mi-hol commented Sep 3, 2023 •

Copy link
Copy Markdown
Contributor Author

I receive these warnings from the start

Seems I had an outdated docusaurus version installed.
Maybe there is a way to specify a minimum version?

@karniv00l

Copy link
Copy Markdown
Member

Seems I had an outdated docusaurus version installed. Maybe there is a way to specify a minimum version?

Dependencies are locked in package-lock.json
Whenever this file changes, you need to run npm install

@nmschulte

Copy link
Copy Markdown
Contributor

Whenever this file changes, you need to run npm install

Note that install may also update packages (in certain contexts), if they are "loosely" versioned (with prefixes like ^ or ~ or so); npm ci will ensure node_modules/ always has versions exactly matching package-lock.json, so I tend to prefer (and recommend) npm ci to avoid any potential mud in the water.

@nmschulte nmschulte left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, looks good; thank you!

@nmschulte
nmschulte merged commit f97854b into FOME-Tech:master Sep 4, 2023
@mi-hol
mi-hol deleted the sidebar_order branch September 11, 2023 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants