feat(api/iota): endofunctors#1191
Open
poolcritter wants to merge 2 commits into
Open
Conversation
IridescentVoid
requested changes
Jul 8, 2026
IridescentVoid
requested changes
Jul 8, 2026
IridescentVoid
left a comment
IridescentVoid
left a comment
Contributor
There was a problem hiding this comment.
Code-Review: -1
Implementation of visitChildren should be made more readable. I would like to at least see full-length variable names.
I'd also like feedback from others on the API design since changing this later would be a breaking change.
IridescentVoid
added
enhancement
poolcritter
force-pushed
the
push-nvtvkvszxopq
branch
from
d8fddcb to
59bb512
Compare
|
|
||
| @Override | ||
| protected Iota visitChildren(UnaryOperator<Iota> visitor) { | ||
| var out = new ArrayList(); |
Contributor
There was a problem hiding this comment.
Suggested change
| var out = new ArrayList(); | |
| var out = new ArrayList<Iota>(); |
Other than this, looks good to merge if there are no other comments on the api design. Not good to merge, I'm pretty sure the logic is wrong.
IridescentVoid
requested changes
Jul 9, 2026
| var out = new ArrayList(); | ||
| boolean conserve = true; | ||
| for (Iota orig : getList()) { | ||
| var replacement = visitor.apply(orig); |
Contributor
There was a problem hiding this comment.
Suggested change
| var replacement = visitor.apply(orig); | |
| var replacement = orig.visit(visitor); |
Change-Id: I6f4fdb764e727fa211db96140ba2b6f26a6a6964
poolcritter
force-pushed
the
push-nvtvkvszxopq
branch
from
59bb512 to
2b04f92
Compare
adds `visit` and `visitChildren` to iotas letting you apply a UnaryOperator to an entire tree of them. this is like hexal's IMappableIota except I don't know if that does self pre or post (or if it does self at all). awa. I haven't tested this in prod; hex doesn't have anything that would use this yet. @IridescentVoid I believe you have a patch that may want to use this? Cc: @IridescentVoid Change-Id: Ic464f4702ba9b0379c93e31723e2a5fe6a6a6964 Issue: closes FallingColors#1083
poolcritter
force-pushed
the
push-nvtvkvszxopq
branch
from
2b04f92 to
eded368
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds
visitandvisitChildrento iotas letting you apply a UnaryOperator to an entire tree of them. this is like hexal's IMappableIota except I don't know if that does self pre or post (or if it does self at all). awa.I haven't tested this in prod; hex doesn't have anything that would use this yet. @IridescentVoid I believe you have a patch that may want to use this?
Cc: @IridescentVoid
Change-Id: Ic464f4702ba9b0379c93e31723e2a5fe6a6a6964
Issue: closes #1083