Skip to content

Add consent dialog to comply with Firefox Addon Guidelines - #1108

Merged
NotAProton merged 3 commits into
FastForwardTeam:mainfrom
big-dump-pro-max:main
Sep 21, 2023
Merged

Add consent dialog to comply with Firefox Addon Guidelines#1108
NotAProton merged 3 commits into
FastForwardTeam:mainfrom
big-dump-pro-max:main

Conversation

@driedpampas

@driedpampas driedpampas commented Sep 17, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix(es):
Added a consent page.

Tasks:

  • consent page disappeared 💀
  • remember users choice
  • Make buttons work again (broke when transitioned to mv3)
  • I made sure there are no unnecessary changes in the code;
  • Tested on Chromium (Includes Opera, Brave, Vivaldi, Edge, etc);
  • Tested on Firefox.

@driedpampas

driedpampas commented Sep 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

update: everything seems to work, though I'll need some other folks to test it out as well, signed xpi link.
I'll update the link when I get the theming sorted out.

@driedpampas
driedpampas marked this pull request as ready for review September 18, 2023 17:44
@driedpampas

driedpampas commented Sep 18, 2023

Copy link
Copy Markdown
Contributor Author

Since the choice is remembered, the pr is functionally ready.

@driedpampas driedpampas mentioned this pull request Sep 18, 2023
Closed
@driedpampas

driedpampas commented Sep 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Resolved I need testers for Chrome because I got this error, but the extension seems to be working...

@NotAProton
NotAProton self-requested a review September 18, 2023 19:22
@github-actions

github-actions Bot commented Sep 18, 2023 •
edited
Loading

Copy link
Copy Markdown

Download the artifacts for this pull request:

NotAProton
NotAProton requested changes Sep 18, 2023
View reviewed changes
Comment thread .github/workflows/main.yml Outdated
Comment thread src/html/consent.html
Comment thread src/js/background.js
NotAProton
NotAProton reviewed Sep 18, 2023
View reviewed changes
Comment thread src/html/consent.js Outdated
@NotAProton

NotAProton commented Sep 19, 2023

Copy link
Copy Markdown
Member

squash your commits please

@driedpampas

driedpampas commented Sep 19, 2023

Copy link
Copy Markdown
Contributor Author

squash your commits please

at school rn I'll squash them when i get home

@driedpampas
driedpampas force-pushed the main branch 2 times, most recently from cfc3d6d to acd6991 Compare September 19, 2023 12:18
@driedpampas

driedpampas commented Sep 19, 2023

Copy link
Copy Markdown
Contributor Author

the way i cant squash all my commits bc i used the testing branch 💀

@driedpampas
driedpampas force-pushed the main branch 2 times, most recently from acd6991 to 028fff7 Compare September 19, 2023 12:35
@driedpampas

driedpampas commented Sep 19, 2023

Copy link
Copy Markdown
Contributor Author

i downloaded my changed files and im doing something very stupid - force pushing my branch to before my changes and adding everything back in one commit

@driedpampas
driedpampas force-pushed the main branch 2 times, most recently from 5684450 to 96ced7d Compare September 19, 2023 12:56
@driedpampas

driedpampas commented Sep 19, 2023

Copy link
Copy Markdown
Contributor Author

@NotAProton is it better now

@driedpampas
feat: consent page (firefox only)
e2145cb 
fix: background.js

Add files via upload
@driedpampas

driedpampas commented Sep 19, 2023

Copy link
Copy Markdown
Contributor Author

wha-
image

@NotAProton

NotAProton commented Sep 19, 2023

Copy link
Copy Markdown
Member

looks like you found a bug in #1101

NotAProton
NotAProton approved these changes Sep 19, 2023
View reviewed changes

@NotAProton NotAProton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i hate git

@lostdusty
lostdusty self-requested a review September 19, 2023 20:13
@driedpampas driedpampas mentioned this pull request Sep 21, 2023
Closed
@NotAProton
NotAProton merged commit 7fa0e83 into FastForwardTeam:main Sep 21, 2023
@lostdusty lostdusty linked an issue Sep 21, 2023 that may be closed by this pull request
FastForward taken down from Firefox Add-ons? #920
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lostdusty lostdusty lostdusty approved these changes
@NotAProton NotAProton NotAProton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FastForward taken down from Firefox Add-ons?

3 participants

@driedpampas @NotAProton @lostdusty