Conversation
Code Review ✅ Approved🟡 Medium risk Fixes forward Object Id references resolved within typed arrays by updating the accumulator when builder-to-value rebinding occurs before array allocation. Regression tests added for single and repeated forward references, both of which would fail with Review coverageRules No rules evaluated OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6225.
When a later element resolves a forward Object Id reference in the same typed array, the builder-to-value rebind occurs before the array is allocated. Update the accumulator in that case too, so the final array receives the built value rather than the transient builder.
Adds regressions for a single forward reference and repeated references to multiple ids, including a null element. Both new tests fail with
ArrayStoreExceptionbefore the fix.Validation: full Maven verify on JDK17 and21 (6,189 tests each, one skipped), plus the JDK17 Android API34 compatibility check. JDK25 and other operating systems were not run locally.