Repository navigation
[FEAT] task:goLiveAsSafe and task:disableTaskManager - #145
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
task:goLiveAsSafe --accounts <a,b>: checks the go-live preconditions (production signers, ACL / PlaintextsStorage / share registry wired, access list on), thenaddToAccessList+enable()through the Safe. Runs withSAFE_OWNER_KEY, otherwise writes one atomic Transaction Builder batch. Idempotent; re-run to verify.task:disableTaskManager: maintenance wallet's emergencydisable(). Sends fromMAINTENANCE_KEY(new, optional), otherwise prints the call for the Ledger..env.exampleupdated.Test plan
test/addressBook/GoLive.ts(8 cases: refusal with access list off, batch path, execute path, no-op re-runs, Ledger print path, non-pauser key refused, disable, re-enable)🤖 Generated with Claude Code
Note
Medium Risk
New operational paths that enable or halt TaskManager intake on mainnet; mitigated by fail-closed prechecks, role checks, and integration tests, but operator error still affects availability.
Overview
Adds mainnet go-live and emergency-stop Hardhat tasks so operators can open or halt TaskManager intake without hand-building Safe transactions.
task:goLiveAsSafe --accounts <a,b>enforces go-live preconditions (production signers, ACL / PlaintextsStorage / share registry wired, access list enabled), then atomicallyaddToAccessListandenable()as the Safe—viaSAFE_OWNER_KEY(direct or through the Safe) or a single Transaction Builder batch when the key is unset. It is idempotent and verifies on re-run.task:disableTaskManagersendsdisable()from optionalMAINTENANCE_KEY, or prints the Ledger call when onlyMAINTENANCE_ADDRESSis configured.Docs (
.env.example, mainnet runbooks, CHANGELOG) andtest/addressBook/GoLive.tscover batch vs execute paths, precondition refusal, and maintenance pause/re-enable.Reviewed by Cursor Bugbot for commit 807b43f. Bugbot is set up for automated code reviews on this repo. Configure here.