Postfixes for PR#8145 - #8571
Merged
Merged
Conversation
aafemt
marked this pull request as ready for review
May 21, 2025 16:09
Contributor
Author
|
Commit "Return isc_dsql_error prefix" has been undone because it caused more problems than solved. |
aafemt
marked this pull request as draft
May 30, 2025 16:23
aafemt
marked this pull request as ready for review
May 31, 2025 21:03
aafemt
marked this pull request as draft
June 1, 2025 08:18
aafemt
marked this pull request as ready for review
June 1, 2025 13:16
Member
dyemanov
self-requested a review
June 15, 2025 13:46
Contributor
Author
|
@asfernandes Do you have a testcase that fail on this build? |
Member
|
Just one question: are your changes really needed for VARCHAR parameters? |
dyemanov
approved these changes
Jul 4, 2025
Contributor
Author
|
IMHO, yes. Some libraries do with them the same as with CHAR: overrun maximum length in characters as derived from maximum length in bytes while still fit to the storage. Besides, it suits to the standard's requirement to silently cut trailing blanks if they don't fit on store. Lastly it may help with API backward compatibility if longer VARCHARs are ever allowed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.