Skip to content

fix: correct CLI version mismatch and add release guard (0.8.1) - #123

Merged
TabishB merged 4 commits into
mainfrom
fix/version-guard-0.8.1
Oct 8, 2025
Merged

TabishB merged 4 commits into
mainfrom
fix/version-guard-0.8.1

Conversation

@TabishB

@TabishB TabishB commented Oct 7, 2025 •

Copy link
Copy Markdown
Contributor

Summary
This PR fixes a packaging mistake where the 0.8.0 tarball printed 0.7.0 via openspec --version due to shipping the internal 0.7.0 package.json.


🧩 Changes

  • Add patch changeset for 0.8.1 (fix CLI version mismatch)

  • Add scripts/pack-version-check.mjs to:

    • Pack the tarball
    • Install it
    • Assert the CLI prints the tarball’s version
  • Update release script to run changeset version + build + pack-version check before publish


🔜 Follow-ups

  • Deprecate 0.8.0 on npm:

    npm deprecate @fission-ai/openspec@0.8.0 "Incorrect internal version. Upgrade to 0.8.1."


✅ After Merge

  • Run:

    pnpm run release
    (or let CI publish)

  • Verify:

    npx @fission-ai/openspec@0.8.1 --version
    → should print 0.8.1


TabishB and others added 4 commits October 7, 2025 15:41
…h changeset for 0.8.1\n- Add pack-version check to validate tarball version\n- Update release script to include versioning and guard
…\n\n- Run pack-version check before publish only\n- Remove redundant changeset version + explicit build in release script\n- Always cleanup temp dir and tgz\n- Quieter, faster npm install during guard
…d\n\n- Add scripts: release:ci (no version), release:local (runs changeset version)\n- Workflow uses release:ci to ensure version PR bump precedes publish\n- Pack guard: document npm vs pnpm choice; improve JSON fallback handling
@TabishB
TabishB merged commit d070d08 into main Oct 8, 2025
6 checks passed
drvova pushed a commit to drvova/VovaSpec that referenced this pull request Oct 13, 2025
…ion-AI#123)

* fix: correct CLI version mismatch and add release guard\n\n- Add patch changeset for 0.8.1\n- Add pack-version check to validate tarball version\n- Update release script to include versioning and guard

* chore(release): simplify release script and harden pack-version-check\n\n- Run pack-version check before publish only\n- Remove redundant changeset version + explicit build in release script\n- Always cleanup temp dir and tgz\n- Quieter, faster npm install during guard

* chore(release): clarify CI vs local release scripts; refine pack guard\n\n- Add scripts: release:ci (no version), release:local (runs changeset version)\n- Workflow uses release:ci to ensure version PR bump precedes publish\n- Pack guard: document npm vs pnpm choice; improve JSON fallback handling
@coderabbitai coderabbitai Bot mentioned this pull request Jan 11, 2026
1 of 3 tasks
@coderabbitai coderabbitai Bot mentioned this pull request Sep 4, 2026
clay-good added a commit to clay-good/OpenSpec that referenced this pull request Sep 7, 2026
alfred-openspec on Fission-AI#1781:

1. The OpenSpec-proposal rule was dropped from the README with nothing
   replacing it, recreating the gap in Fission-AI#1727. New step 2 carries the threshold
   over verbatim from the README (new features, significant refactors,
   architectural changes) plus the philosophy paragraph, says to open the
   proposal as its own PR and wait for approval, and tells anyone unsure to ask
   in the issue from step 1.

2. The discussion path contradicted itself: step 1 accepted a prior discussion
   while step 3 required 'Closes Fission-AI#123'. The PR step now says to link what you
   opened in step 1, 'Closes Fission-AI#123' for an issue or a link to the discussion
   when there is no issue. CodeRabbit's thread on README.md:227 is the same
   defect, so the README sentence says 'the issue or discussion' too.

3. The local setup was missing 'pnpm exec tsc --noEmit', which CI runs, and the
   README called the guide a development setup after 'pnpm run dev' and
   'dev:cli' were removed. The command is added, the guide states that those
   four commands are exactly what CI runs, and the README pointer now describes
   the guide as the full process rather than a setup.

Verified each documented command against this checkout: build, tsc --noEmit and
lint all pass as written.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
clay-good added a commit to dwin-gharibi/OpenSpec that referenced this pull request Sep 9, 2026
* docs: add CONTRIBUTING.md

Require a discussion (core design changes) or an issue before a PR is
opened, and require every PR to link its issue.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* docs: add setup and PR steps to CONTRIBUTING.md

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* docs: make CONTRIBUTING.md the single source for the process

The README's Contributing section said small fixes could go straight to
a PR, which contradicts the new discussion/issue requirement. Point it at
CONTRIBUTING.md and carry over the conventional-commit and AI-disclosure
policies so nothing is lost.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* docs: close the three process gaps in CONTRIBUTING.md

alfred-openspec on Fission-AI#1781:

1. The OpenSpec-proposal rule was dropped from the README with nothing
   replacing it, recreating the gap in Fission-AI#1727. New step 2 carries the threshold
   over verbatim from the README (new features, significant refactors,
   architectural changes) plus the philosophy paragraph, says to open the
   proposal as its own PR and wait for approval, and tells anyone unsure to ask
   in the issue from step 1.

2. The discussion path contradicted itself: step 1 accepted a prior discussion
   while step 3 required 'Closes Fission-AI#123'. The PR step now says to link what you
   opened in step 1, 'Closes Fission-AI#123' for an issue or a link to the discussion
   when there is no issue. CodeRabbit's thread on README.md:227 is the same
   defect, so the README sentence says 'the issue or discussion' too.

3. The local setup was missing 'pnpm exec tsc --noEmit', which CI runs, and the
   README called the guide a development setup after 'pnpm run dev' and
   'dev:cli' were removed. The command is added, the guide states that those
   four commands are exactly what CI runs, and the README pointer now describes
   the guide as the full process rather than a setup.

Verified each documented command against this checkout: build, tsc --noEmit and
lint all pass as written.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
clay-good added a commit that referenced this pull request Oct 9, 2026
- Ignore HTML comments in the PR body, so the template's own
  "Part of #123" example is never read as the link.
- Require `Part of #N` on proposal PRs and `Closes #N` on implementation
  PRs, so a proposal no longer closes its feature issue on merge.
- Accept the `Closes: #N` colon form GitHub also accepts.
- Only touch comments this workflow posted (github-actions[bot]), never
  another bot's, and tolerate deleted users.
- bug-repro: look for steps under a reproduce heading or a "Steps to
  reproduce" line, not the first sentence that says "reproduce".
- README: replace the old discussion-first contributing line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant