Read SPIDER breakdown badges from its per-tier test counts#41
Open
timlichtenberg wants to merge 1 commit into
Open
Read SPIDER breakdown badges from its per-tier test counts#41timlichtenberg wants to merge 1 commit into
timlichtenberg wants to merge 1 commit into
Conversation
SPIDER now publishes tests-unit.json, tests-smoke.json, and tests-integration.json on its badges branch, so the unit and integration badges on the validation page can read the real per-tier counts (19 unit, 3 integration) instead of borrowing the fast and nightly suite counts as stand-ins. The badge links now point at the per-tier JSON files as well. Total stays 64; regenerating the badges confirms the new figures render.
Member
|
@timlichtenberg do you want me to review this one? I am fine with these (mostly aesthetic/expositional) changes being merged directly. |
Member
Author
|
No that's fine. I am still dealing with that you are added automatically added to all PRs basically. Not sure what to do about this. |
|
All website maintainers (including me) are automatically notified I think, I don't think we can do much about it. I guess if you need an actual review, you'd have to tag us explicitly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does: Points the SPIDER unit and integration badges on the validation page at SPIDER's new per-tier test-count files, so the breakdown shows the real tier counts (19 unit, 3 integration) instead of the fast and nightly suite counts that stood in for them.
Why: SPIDER now publishes tests-unit.json, tests-smoke.json, and tests-integration.json on its badges branch, so the stand-in mapping is no longer needed.
Changes:
data/test_counts.yml: SPIDER markers read tests-unit.json and tests-integration.json.
src/pages/validation.astro: the two breakdown badge links point at the per-tier JSON files.
Testing: Curl-verified all three per-tier endpoints and both GitHub blob links, regenerated the badges (unit renders 19, integration 3, total unchanged at 64), and ran a full site build.