Conversation
This was referenced Sep 24, 2026
niemyjski
changed the base branch from
feature/rabbitmq-tls-endpoints
to
feature/rabbitmq-quorum-priority
September 24, 2026 16:20
niemyjski
added this pull request to stack #107
September 25, 2026 20:21
niemyjski
force-pushed
the
feature/rabbitmq-broker-verification
branch
from
September 25, 2026 20:21
1e60363 to
2f4833d
Compare
niemyjski
force-pushed
the
feature/rabbitmq-broker-verification
branch
2 times, most recently
from
September 25, 2026 20:34
bf191fb to
2802006
Compare
niemyjski
force-pushed
the
feature/rabbitmq-broker-verification
branch
2 times, most recently
from
September 25, 2026 21:34
a49ed95 to
4ed5391
Compare
niemyjski
force-pushed
the
feature/rabbitmq-broker-verification
branch
from
September 25, 2026 21:40
4ed5391 to
de1caa2
Compare
niemyjski
force-pushed
the
feature/rabbitmq-broker-verification
branch
from
September 25, 2026 21:49
de1caa2 to
7887090
Compare
niemyjski
force-pushed
the
feature/rabbitmq-broker-verification
branch
2 times, most recently
from
September 26, 2026 02:20
ce65787 to
827f7a1
Compare
niemyjski
force-pushed
the
feature/rabbitmq-broker-verification
branch
2 times, most recently
from
September 29, 2026 02:04
d1aa2a0 to
45b344a
Compare
niemyjski
force-pushed
the
feature/rabbitmq-broker-verification
branch
from
October 2, 2026 03:28
45b344a to
0fc7840
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broker tests share owned Aspire infrastructure with real TLS verification. CI fails when required infrastructure cannot start. The main suite stays on RabbitMQ 4.2.5; a dedicated 4.3.6 broker runs the new priority upgrade cases alongside the 4.2.5 cases.
Runtime impact: test infrastructure only. Library behavior and production broker permissions are unchanged. TLS tests install a temporary certificate authority in the current user's trust store and remove it during cleanup; optional local TLS tests can skip if that installation is denied. CI starts one additional broker for priority compatibility coverage.
Validation: Release build and formatting passed. The nine new cases passed without skips on 3.13.7, 4.2.5, and 4.3.6 locally. All updated-head Linux checks passed. The push run passed 300 tests with only five expected skips from the earlier strict-quorum test on 4.2. The 19 new cases ran: nine each on 4.2.5 and 4.3.6, plus the upgrade-fixture version check.
Verification and implementation details
The version matrix compares fresh brokers. A rolling upgrade with existing queue data was not exercised.
The main, TLS, delayed-plugin, and chaos brokers remain pinned to 4.2.5. The new priority broker uses
4.3.6-managementand shares the existing collection fixture and startup/cleanup lifecycle. It provides priority and routing coverage, not a complete 4.3 runtime certification.The independent priority scenarios inherited from #106 run with version-specific assertions on both CI brokers. They cover queued ordering, omitted/zero priority, fairness, publication before subscription, and delivery already in progress. The earlier strict quorum test still skips on 4.2.5; the new cases do not skip older broker versions. None of the existing test methods change in this latest addition.
Earlier changes move fixture declarations to a shared collection. The disconnect test additionally verifies that a delivery occurred, closes the actual broker connection, and releases its blocked handler before disposal; disposal alone did not simulate an abrupt disconnect. The TCP relay forwards opaque bytes to test certificate-name failures and connection loss without weakening TLS validation. Shutdown awaits the accept loop and tunnels. Temporary certificates use asynchronous file writes and a private parent directory; broker commands target owned containers.
Merge after #106 and before #105.