Move the proto-free vector index test helpers into the core test fixtures - #4678
Draft
normen662 wants to merge 1 commit into
Conversation
…ures Add `VectorIndexTestSupport` to the core test fixtures with the vector index test helpers that don't depend on a record proto: merging a vector index (once, or to completion) and checking it for outstanding work, building a by-distance index plan for a query vector of any precision and dimensionality, inserting a batch with retries, and checking the Guardiann structure and recall of a record-store vector index. `VectorIndexTestBase` and `GuardiannVectorIndexConcurrentMergeTest` delegate to it, so their behavior is unchanged.
normen662
added this pull request to stack #4679
September 27, 2026 10:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the vector index test helpers that don't depend on a record proto from
VectorIndexTestBaseandGuardiannVectorIndexConcurrentMergeTestinto a newVectorIndexTestSupportin the core test fixtures, so that they are published with them (see #4676) and can be reused with other record protos.VECTOR(128, HALF)).VectorIndexClusterTooLargeException.Guardiannview of a record-store vector index, the Guardiann structure checks, and recall@k.VectorIndexTestBase(which stays insrc/test, with its proto) andGuardiannVectorIndexConcurrentMergeTestdelegate to it; their signatures and behavior are unchanged (the index plans built for the existing 128-dimensional half-precision callers are identical, including plan hashes and serialization). The core test fixtures now expose thefdb-extensionstest fixtures as an API dependency.Verified: the vector index and Guardiann tests of
fdb-record-layer-corepass;VectorIndexTestSupportis part of the published test fixtures jar (it doesn't reference any proto);checkpasses.