Conversation
The class grew two methods that measured rather than asserted: one tallied every delete against the candidate set it should have used, the other counted node writes and bytes per delete. Both were written to answer questions about the delete path and answered them; neither asserts anything a regression would trip, and together they were about 450 lines. Removed, along with the helpers only they used. The remaining ten tests each assert a property: that a search centered on a node's own vector finds it, that no node runs out of usable outgoing edges, that some node can still reach all the others, that a delete reaps references naming deleted nodes, and that the reap callback reports even when it reaped nothing. Also quieted the logging. Progress lines that fired every round or once per seed regardless of outcome are now behind isDebugEnabled; the warn level is left to the cases that precede an assertion failure, where the context is worth having.
normen662
added this pull request to stack #4688
September 29, 2026 09:14
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ChurnReachabilityTestgrew two methods that measured rather than asserted. One talliedevery delete against the candidate set it should have used; the other counted node writes
and bytes written per delete. Both were written to answer specific questions about the
delete path and they answered them. Neither asserts anything that a regression would trip,
and together they accounted for about 450 lines.
The class also logged at warn level on every round and once per seed regardless of outcome,
so a successful run printed hundreds of lines.
Change
Remove both methods and the helpers only they used.
Ten tests remain, each asserting a property: that a search centered on a node's own vector
finds it, that no node runs out of usable outgoing edges, that some node can still reach all
the others, that a delete removes references naming deleted nodes, and that the
corresponding callback reports even when it removed nothing.
Move the progress logging behind
isDebugEnabled. The warn level is left to the cases thatprecede an assertion failure, where the context is worth having. A successful run of the
suite now prints no warn lines at all.