While reviewing #762, @beojan found name shadowing in storage_reader.cpp here:
|
auto key = std::make_pair(token.fileName(), token.containerName()); |
There's a similar problem a few lines down the same file. Based on how I helped create these files, storage_writer.cpp should be scanned for this problem too.
This name shadowing doesn't affect the correctness of our code right now nor in the PR above. But we should fix it to improve readability and prevent future bugs. I plan to solve it in the next two weeks unless someone beats me to it.
While reviewing #762, @beojan found name shadowing in
storage_reader.cpphere:phlex/form/storage/storage_reader.cpp
Line 205 in 93334dd
There's a similar problem a few lines down the same file. Based on how I helped create these files,
storage_writer.cppshould be scanned for this problem too.This name shadowing doesn't affect the correctness of our code right now nor in the PR above. But we should fix it to improve readability and prevent future bugs. I plan to solve it in the next two weeks unless someone beats me to it.