Use zendesk/setup-jsonnet action for reliable go-jsonnet retrieval - #649
Merged
Conversation
greenc-FNAL
requested review from
aolivier23,
knoepfel,
marcpaterno and
sabasehrish
as code owners
June 16, 2026 16:53
Contributor
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughBoth Jsonnet GitHub Actions workflows ( ChangesJsonnet CI Runtime Migration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Author
|
31 fixed, 0 new since branch point (6f38dee) ✅ 31 CodeQL alerts resolved since the previous PR commit
✅ 31 CodeQL alerts resolved since the branch point
Review the full CodeQL report for details. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/jsonnet-format-check.yaml:
- Around line 87-92: The setup-jsonnet action defaults to the latest version
when no version input is specified, which causes formatter behavior to drift
over time. Add `version: v16` to the `with:` block of the setup-jsonnet step in
both `.github/workflows/jsonnet-format-check.yaml` and
`.github/workflows/jsonnet-format-fix.yaml` to ensure both the format check and
format fix workflows use the same Jsonnet CLI version and maintain deterministic
behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 9d2429c0-dfa9-432c-8613-4ff08afc8e70
📒 Files selected for processing (2)
.github/workflows/jsonnet-format-check.yaml.github/workflows/jsonnet-format-fix.yaml
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
Framework-R-D/action-workflow-setup(auto-detected)Framework-R-D/action-complete-pr-comment(auto-detected)Framework-R-D/action-handle-fix-commit(auto-detected)
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze actions with CodeQL
🔇 Additional comments (2)
.github/workflows/jsonnet-format-fix.yaml (2)
103-108: Same version-pinning concern as above applies here.
114-114: LGTM!
knoepfel
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI/CD
Jsonnet tooling provisioning: Replaced Docker container-based Jsonnet runtime (
docker.io/dysnix/jsonnet:latest) with explicit action-based setup in both workflowsjsonnet-format-check.yaml: AddedSetup jsonnetstep usingzendesk/setup-jsonnet@v16(pinned to74119dac8a540c99167a65f14aa1ee99ff143ec2) withgithub_tokenparameterjsonnet-format-fix.yaml: AddedSetup jsonnetstep using the samezendesk/setup-jsonnet@v16action withgithub_tokenparameterCommand execution: Both workflows now execute
jsonnetfmtdirectly on the GitHub Actions runner instead of within a Docker container:jsonnetfmt --teston all*.jsonnetand*.libsonnetfiles to validate formattingjsonnetfmt -ito apply formatting fixes in-placeRationale: The
zendesk/setup-jsonnetaction provides reliable, automatedgo-jsonnetbinary retrieval and setup, improving reproducibility and reducing dependency on external Docker images