clang-tidy: resolve modernize-use-emplace - #793
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThe Python callback wrapper now uses ChangesEmplace modernization
Estimated code review effort: 2 (Simple) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #793 +/- ##
=======================================
Coverage 83.80% 83.80%
=======================================
Files 172 172
Lines 7230 7230
Branches 850 850
=======================================
Hits 6059 6059
Misses 889 889
Partials 282 282
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Resolve
modernize-use-emplaceclang-tidy warnings.Code quality
modernize-use-emplacewarning in the Python module wrapper by replacingpush_back(dcarg{m_callable})withemplace_back(m_callable).Documentation
modernize-use-emplaceas completed and linked it to PR#793in the clang-tidy fixes documentation.