Skip to content

clang-tidy: resolve modernize-use-emplace - #793

Merged
knoepfel merged 2 commits into
Framework-R-D:mainfrom
knoepfel:modernize-use-emplace
Aug 3, 2026
Merged

clang-tidy: resolve modernize-use-emplace#793
knoepfel merged 2 commits into
Framework-R-D:mainfrom
knoepfel:modernize-use-emplace

Conversation

@knoepfel

@knoepfel knoepfel commented Jul 30, 2026

Copy link
Copy Markdown
Member

Resolve modernize-use-emplace clang-tidy warnings.

  • Code quality

    • Resolved the modernize-use-emplace warning in the Python module wrapper by replacing push_back(dcarg{m_callable}) with emplace_back(m_callable).
  • Documentation

    • Marked modernize-use-emplace as completed and linked it to PR #793 in the clang-tidy fixes documentation.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: ee3a71a7-edfe-4488-aef2-8dd9057e98d8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

The Python callback wrapper now uses emplace_back for the callable argument. The developer checklist marks modernize-use-emplace complete and references PR 793.

Changes

Emplace modernization

Layer / File(s) Summary
Callback argument insertion
plugins/python/src/modulewrap.cpp
The callable is added with emplace_back, while lifeline transformations and the trailing sentinel remain unchanged.
Clang-tidy checklist tracking
docs/dev/clang-tidy-fixes-2026-04.md
The modernize-use-emplace item is checked and linked to PR 793.

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

Suggested reviewers: gemmeren, beojan, greenc-fnal

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: resolving the modernize-use-emplace clang-tidy warning.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main     #793   +/-   ##
=======================================
  Coverage   83.80%   83.80%           
=======================================
  Files         172      172           
  Lines        7230     7230           
  Branches      850      850           
=======================================
  Hits         6059     6059           
  Misses        889      889           
  Partials      282      282           
Flag Coverage Δ
scripts 80.09% <ø> (ø)
unittests 85.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
plugins/python/src/modulewrap.cpp 75.48% <100.00%> (+0.12%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d64c9ba...e0c676b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@knoepfel
knoepfel merged commit 77ed9fb into Framework-R-D:main Aug 3, 2026
40 checks passed
@knoepfel
knoepfel deleted the modernize-use-emplace branch August 3, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants