feat: Well Estimator + Constraint Selector - #3735
Closed
tjb-ltk wants to merge 51 commits into
Closed
Conversation
…m for each well, 2) refactor accum/flux/presrelation calcs
…Newton for now, incl well dbg for now, compo1&2d run
… skip calcs if well not open, 3) parallel estimator works on a few cases tested
…initialization - part 1
…new&old logic, add basic basic constraint selection
…tor w/well estimator, 3) split constraint derivatives from well rate calculations, 4) add kernels for active constraint jacgen calcs , 5) needs testing
tjb-ltk
requested review from
CusiniM,
castelletto1,
frankfeifan,
jhuang2601,
paveltomin and
rrsettgast
as code owners
July 18, 2025 21:57
paveltomin
changed the title
…OS into feature/byer3/well_estimator
…& rates, minimizes risk of failed estimator solve for non-physical constraints,(present in many of the integrated test models)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add well estimator solve assuming fixed reservoir conditions
Refactor constraint specification
Introduced concept of well separator internally to remove ambiguity of fluid model quantities encountered when using same fluid model for constraint flashes and well element calculations. No input schema changes. This should be under separate PR to include formal well separator schema
Introduced limiting constraint selector to work with well estimator. At the beginning of the first n Newton Iterations , for each constraint, the well estimator applied and the most limiting constraint selected and set as the active constraint for the remaining Newton iterations.
PR currently has a fair bit of well debug code that will be removed