fix: change validation for region statistics for by resvol constraint

[tjb-ltk]

Reservoir volume constraint needs region average quantities for computing fluid properties. The ave quantities are computed via tasks such as CompositionalMultiphaseStatistics (and SinglePhaseStatistics equivalent) that are triggered in event section
Previously validation attempted to check if compute statistics wrappers were present on region. This was incorrect. but maybe the region should own the statistics object.

New check looks at if region ave quantities are zero.

integrated tests are forthcoming..

[MelReyCG]

Maybe, to not expose the statistics component to the user, you can add in the well solver's registerDataOnMesh():

if( !wellControls.referenceReservoirRegion().empty() )
{
  // we need a statistics component for reference region pressure
  m_referenceRegionStats = taskManager.registerGroup<SinglePhaseStatistics>( "internalStats" )
    .setRestartFlags(NO_WRITE);
  m_referenceRegionStats.registerDataOnMeshRecursive(meshBodies);
}

m_referenceRegionStats would be a pointer or an std::optional, then you can call its execute() before reading it in updateVolRateForConstraint()

[MelReyCG]

We are testing the current state of the branch

[MelReyCG]

No success. I'll create a branch / PR on top of this one to contribute on this issue

[codecov]

Codecov Report

❌ Patch coverage is 60.46512% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.36%. Comparing base (e68e1bc) to head (8c74292).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines	Patch %	Lines
...physicsSolvers/fluidFlow/wells/SinglePhaseWell.cpp	52.38%	10 Missing ⚠️
...rs/fluidFlow/wells/CompositionalMultiphaseWell.cpp	61.11%	7 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3829   +/-   ##
========================================
  Coverage    59.36%   59.36%           
========================================
  Files         1337     1337           
  Lines       110815   110821    +6     
========================================
+ Hits         65788    65792    +4     
- Misses       45027    45029    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.