Skip to content

fix: SinglePhaseWell Thermal - #4126

Merged
victorapm merged 13 commits into
developfrom
fix/byer3/singlephasewell
Sep 4, 2026
Merged

fix: SinglePhaseWell Thermal#4126
victorapm merged 13 commits into
developfrom
fix/byer3/singlephasewell

Conversation

@tjb-ltk

@tjb-ltk tjb-ltk commented Aug 19, 2026

Copy link
Copy Markdown
Contributor
  1. fix numdof for shutwell matrix assembly , set to 2 for and should be 3
  2. add missing perforation rate contribution to well system only solve

Compositional wells were correct. The code was refactored a bit to avoid duplication in matrix stamping and Dof definition

@tjb-ltk
1) fix numdof for shutwell matrix assembly , 2) add missing perforati…
f9a782a 
…on contribution to well system when solving well only system . These are singlephase only issues
@tjb-ltk tjb-ltk self-assigned this Aug 19, 2026
@tjb-ltk tjb-ltk added ci: run CUDA builds ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline ci: run code coverage enables running of the code coverage CI jobs labels Aug 19, 2026
frankfeifan
frankfeifan reviewed Aug 20, 2026
View reviewed changes
Comment thread src/coreComponents/physicsSolvers/fluidFlow/wells/SinglePhaseWell.cpp Outdated
@herve-gross
herve-gross requested a review from victorapm August 27, 2026 16:45
@herve-gross

herve-gross commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

@dkachuma can you take a look at this PR? Thanks.

@victorapm victorapm added ci: run device builds Allows to run the device (CUDA/HIP) builds and removed ci: run CUDA builds labels Aug 27, 2026
dkachuma
dkachuma reviewed Aug 28, 2026
View reviewed changes

@dkachuma dkachuma left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Comment thread src/coreComponents/physicsSolvers/fluidFlow/wells/CompositionalMultiphaseWell.cpp Outdated
Comment thread src/coreComponents/physicsSolvers/multiphysics/CoupledReservoirAndSinglePhaseWellKernels.hpp Outdated
Comment thread src/coreComponents/physicsSolvers/fluidFlow/wells/CompositionalMultiphaseWell.cpp
@victorapm

victorapm commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Just need to address @dkachuma comments and this is ready to merge

@victorapm
victorapm merged commit b7a0f13 into develop Sep 4, 2026
22 checks passed
@victorapm
victorapm deleted the fix/byer3/singlephasewell branch September 4, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dkachuma dkachuma dkachuma left review comments
@frankfeifan frankfeifan frankfeifan approved these changes
@victorapm victorapm victorapm approved these changes
@jhuang2601 jhuang2601 jhuang2601 approved these changes
@rrsettgast rrsettgast Awaiting requested review from rrsettgast rrsettgast is a code owner
@OmarDuran OmarDuran Awaiting requested review from OmarDuran OmarDuran is a code owner

Assignees

@tjb-ltk tjb-ltk

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run device builds Allows to run the device (CUDA/HIP) builds ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tjb-ltk @herve-gross @victorapm @frankfeifan @jhuang2601 @dkachuma