Skip to content

test(host): script specs start from a sanitized environment (gh-#776) #782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
genwave-radio merged 6 commits into from
Sep 15, 2026
Merged

test(host): script specs start from a sanitized environment (gh-#776) #782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
854f953
Merge branch 'fix/build-without-launch-prereqs-775' into test/script-…
genwave-radio Sep 15, 2026
dc34659
test(host): STORY-438 red specs — script specs start from a sanitized…
genwave-radio Sep 15, 2026
fff4a91
test(host): T473 ScriptProcess helper starts scripts from a sanitized…
genwave-radio Sep 15, 2026
133d75b
test(host): T474 every script-driving spec starts through ScriptProce…
genwave-radio Sep 15, 2026
80f4cc5
Merge remote-tracking branch 'origin/main' into test/script-env-isola…
genwave-radio Sep 15, 2026
684fb76
Merge remote-tracking branch 'origin/main' into test/script-env-isola…
genwave-radio Sep 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
122 changes: 21 additions & 101 deletions tests/GenWave.Host.Tests/Specs/Gh019_ScriptPreflight.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,71 +7,17 @@
//
// Isolation: each scenario runs the script with PATH pointed at a scratch bin directory holding
// symlinks to the coreutils the scripts need plus (per scenario) a scripted `docker`/`dotnet`
// stub — "docker not installed" is simply a PATH without one. The six required .env secrets are
// scrubbed from the child environment and GW_ENV_FILE (a preflight-only test seam) points at a
// scratch env file, so the developer's real .env and shell exports can never sway an assertion.
// stub — "docker not installed" is simply a PATH without one. The child starts from
// ScriptProcess's sanitized environment (gh-#776) and GW_ENV_FILE (a preflight-only test seam)
// points at a scratch env file, so the developer's real .env and shell exports can never sway
// an assertion.

using System.Diagnostics;
using GenWave.Host.Tests.Support;

namespace GenWave.Host.Tests.Specs;

public static class FeatureScriptPreflight
{
static readonly string[] RequiredEnvVars =
[
"POSTGRES_PASSWORD", "LIBRARY_DB_PASSWORD", "STATION_DB_PASSWORD",
"ICECAST_SOURCE_PASSWORD", "ICECAST_ADMIN_PASSWORD", "MEDIA_DIR",
];

/// <summary>Coreutils the scripts themselves need — everything else is deliberately absent.</summary>
static readonly string[] BaseTools =
["bash", "sh", "grep", "tail", "cut", "seq", "sleep", "awk", "dirname", "cat", "paste"];

static string RepoRoot()
{
var dir = new DirectoryInfo(AppContext.BaseDirectory);
while (dir is not null && !File.Exists(Path.Combine(dir.FullName, "GenWave.sln")))
dir = dir.Parent;

if (dir is null) throw new InvalidOperationException("repo root (GenWave.sln) not found");
return dir.FullName;
}

static string ResolveTool(string tool)
{
foreach (var dir in (Environment.GetEnvironmentVariable("PATH") ?? "").Split(':'))
{
var candidate = Path.Combine(dir, tool);
if (File.Exists(candidate))
return candidate;
}
throw new InvalidOperationException($"required tool not on PATH: {tool}");
}

/// <summary>A scratch bin dir with the coreutils symlinked in and nothing else.</summary>
static string MakeBinDir()
{
var dir = Directory.CreateTempSubdirectory("gw-preflight-bin-").FullName;
foreach (var tool in BaseTools)
File.CreateSymbolicLink(Path.Combine(dir, tool), ResolveTool(tool));
return dir;
}

static void AddStub(string binDir, string name, string body)
{
var path = Path.Combine(binDir, name);
File.WriteAllText(path, "#!/usr/bin/env bash\n" + body + "\n");
// The scripts under test are bash — these specs only ever run on a Unix host (CI + dev
// are both Linux); the guard exists to satisfy CA1416, not to support Windows.
if (!OperatingSystem.IsWindows())
{
File.SetUnixFileMode(path,
UnixFileMode.UserRead | UnixFileMode.UserWrite | UnixFileMode.UserExecute |
UnixFileMode.GroupRead | UnixFileMode.GroupExecute |
UnixFileMode.OtherRead | UnixFileMode.OtherExecute);
}
}

/// <summary>A docker stub whose `docker info` succeeds (daemon "running"), everything else a no-op.</summary>
static string HealthyDockerStub => "exit 0";

Expand All @@ -92,34 +38,8 @@ static string[] CompleteEnvAssignments(string? mediaDir = null) =>

static (int ExitCode, string StdOut, string StdErr) RunScript(
string script, string binDir, string? envFile = null,
IReadOnlyDictionary<string, string>? extraEnv = null, params string[] args)
{
var startInfo = new ProcessStartInfo("bash")
{
WorkingDirectory = RepoRoot(),
RedirectStandardOutput = true,
RedirectStandardError = true,
UseShellExecute = false,
};
startInfo.ArgumentList.Add(Path.Combine(RepoRoot(), script));
foreach (var arg in args) startInfo.ArgumentList.Add(arg);

startInfo.Environment["PATH"] = binDir;
foreach (var name in RequiredEnvVars)
startInfo.Environment.Remove(name);
if (envFile is not null)
startInfo.Environment["GW_ENV_FILE"] = envFile;
if (extraEnv is not null)
foreach (var (key, value) in extraEnv)
startInfo.Environment[key] = value;

using var process = Process.Start(startInfo)
?? throw new InvalidOperationException($"failed to start {script}");
var stdOut = process.StandardOutput.ReadToEnd();
var stdErr = process.StandardError.ReadToEnd();
process.WaitForExit();
return (process.ExitCode, stdOut, stdErr);
}
IReadOnlyDictionary<string, string>? extraEnv = null, params string[] args) =>
ScriptProcess.Run(script, binDir, envFile, extraEnv, args);

// ---------------------------------------------------------------------
// Docker preflight (launch.sh)
Expand All @@ -132,7 +52,7 @@ public static void DryRunStillNeedsNoDockerAndExitsZero()
{
// --dry-run's "touches nothing" contract (STORY-201) survives the gh-#19 preflight:
// the plan prints on a machine with no docker at all.
var (exitCode, stdOut, _) = RunScript("launch.sh", MakeBinDir(), args: "--dry-run");
var (exitCode, stdOut, _) = RunScript("launch.sh", ScriptProcess.MakeBinDir(), args: "--dry-run");

Assert.Equal(0, exitCode);
Assert.Contains("plan> ", stdOut);
Expand All @@ -141,7 +61,7 @@ public static void DryRunStillNeedsNoDockerAndExitsZero()
[Fact]
public static void MissingDockerFailsWithInstallGuidance()
{
var (exitCode, _, stdErr) = RunScript("launch.sh", MakeBinDir());
var (exitCode, _, stdErr) = RunScript("launch.sh", ScriptProcess.MakeBinDir());

Assert.Equal(3, exitCode);
Assert.Contains("Docker is not installed", stdErr);
Expand All @@ -152,8 +72,8 @@ public static void MissingDockerFailsWithInstallGuidance()
[Fact]
public static void DeadDaemonFailsWithStartGuidance()
{
var bin = MakeBinDir();
AddStub(bin, "docker",
var bin = ScriptProcess.MakeBinDir();
ScriptProcess.AddStub(bin, "docker",
"""if [ "${1:-}" = "info" ]; then echo "Cannot connect to the Docker daemon" >&2; exit 1; fi; exit 0""");

var (exitCode, _, stdErr) = RunScript("launch.sh", bin);
Expand All @@ -166,8 +86,8 @@ public static void DeadDaemonFailsWithStartGuidance()
[Fact]
public static void PermissionDeniedFailsWithDockerGroupGuidance()
{
var bin = MakeBinDir();
AddStub(bin, "docker",
var bin = ScriptProcess.MakeBinDir();
ScriptProcess.AddStub(bin, "docker",
"""if [ "${1:-}" = "info" ]; then echo "permission denied while trying to connect to the Docker daemon socket" >&2; exit 1; fi; exit 0""");

var (exitCode, _, stdErr) = RunScript("launch.sh", bin);
Expand All @@ -184,7 +104,7 @@ public static void SkipPreflightBypassesEveryCheck()
// (and then fails at the first real docker call on this deliberately docker-less
// PATH — with a non-preflight error).
var (exitCode, _, stdErr) = RunScript(
"launch.sh", MakeBinDir(), extraEnv: new Dictionary<string, string> { ["SKIP_PREFLIGHT"] = "1" });
"launch.sh", ScriptProcess.MakeBinDir(), extraEnv: new Dictionary<string, string> { ["SKIP_PREFLIGHT"] = "1" });

Assert.NotEqual(0, exitCode);
Assert.DoesNotContain("preflight:", stdErr);
Expand All @@ -199,8 +119,8 @@ public static class ScenarioEnvSecretsPreflight
{
static string HealthyDockerBin()
{
var bin = MakeBinDir();
AddStub(bin, "docker", HealthyDockerStub);
var bin = ScriptProcess.MakeBinDir();
ScriptProcess.AddStub(bin, "docker", HealthyDockerStub);
return bin;
}

Expand Down Expand Up @@ -265,7 +185,7 @@ public static class ScenarioBuildScriptPreflight
[Fact]
public static void MissingDotnetSdkFailsWithInstallGuidance()
{
var (exitCode, _, stdErr) = RunScript("build.sh", MakeBinDir());
var (exitCode, _, stdErr) = RunScript("build.sh", ScriptProcess.MakeBinDir());

Assert.Equal(3, exitCode);
Assert.Contains(".NET SDK is not installed", stdErr);
Expand All @@ -275,8 +195,8 @@ public static void MissingDotnetSdkFailsWithInstallGuidance()
[Fact]
public static void AWrongSdkMajorFailsNamingWhatWasFound()
{
var bin = MakeBinDir();
AddStub(bin, "dotnet",
var bin = ScriptProcess.MakeBinDir();
ScriptProcess.AddStub(bin, "dotnet",
"""if [ "${1:-}" = "--list-sdks" ]; then echo "8.0.100 [/usr/lib/dotnet/sdk]"; exit 0; fi; exit 0""");

var (exitCode, _, stdErr) = RunScript("build.sh", bin);
Expand All @@ -291,8 +211,8 @@ public static void WithASuitableSdkTheDockerCheckIsNext()
{
// dotnet passes, docker is absent — proving check ORDER (tooling before daemon)
// and that build.sh gates on docker too.
var bin = MakeBinDir();
AddStub(bin, "dotnet",
var bin = ScriptProcess.MakeBinDir();
ScriptProcess.AddStub(bin, "dotnet",
"""if [ "${1:-}" = "--list-sdks" ]; then echo "10.0.100 [/usr/lib/dotnet/sdk]"; exit 0; fi; exit 0""");

var (exitCode, _, stdErr) = RunScript("build.sh", bin);
Expand Down
39 changes: 11 additions & 28 deletions tests/GenWave.Host.Tests/Specs/Gh148_ComposeStatsSidecar.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,27 +12,19 @@
using System.Diagnostics;
using System.Text.Json;

using GenWave.Host.Tests.Support;

namespace GenWave.Host.Tests.Specs;

public static class FeatureComposeStatsSidecar
{
const string PinnedImage = "tecnativa/docker-socket-proxy:v0.4.2";

static string RepoRoot()
{
var dir = new DirectoryInfo(AppContext.BaseDirectory);
while (dir is not null && !File.Exists(Path.Combine(dir.FullName, "GenWave.sln")))
dir = dir.Parent;

if (dir is null) throw new InvalidOperationException("repo root (GenWave.sln) not found");
return dir.FullName;
}

static JsonDocument RenderConfig(bool demoOverlay)
{
var startInfo = new ProcessStartInfo("docker")
{
WorkingDirectory = RepoRoot(),
WorkingDirectory = RepoRootLocator.Find(AppContext.BaseDirectory),
RedirectStandardOutput = true,
RedirectStandardError = true,
UseShellExecute = false,
Expand Down Expand Up @@ -145,29 +137,20 @@ public static class SadPathSocketGuardCoversTheSidecar
{
const string SocketSource = "/var/run/docker.sock";

// This guard runs against the real toolchain (jq, bash) on the developer's own PATH, not
// a scratch bin — ScriptProcess still starts the child from its sanitized environment
// (gh-#776).
static readonly string RealPath = Environment.GetEnvironmentVariable("PATH") ?? "/usr/bin:/bin";

static (int ExitCode, string Output) RunGuardAgainstFixture(string fixtureJson)
{
var fixturePath = Path.Combine(Path.GetTempPath(), $"gh148-socket-{Guid.NewGuid():N}.json");
File.WriteAllText(fixturePath, fixtureJson);
try
{
var startInfo = new ProcessStartInfo("bash")
{
WorkingDirectory = RepoRoot(),
RedirectStandardOutput = true,
RedirectStandardError = true,
UseShellExecute = false,
};
startInfo.ArgumentList.Add(Path.Combine(RepoRoot(), "tools", "check-compose-socket.sh"));
startInfo.ArgumentList.Add("--config-file");
startInfo.ArgumentList.Add(fixturePath);

using var process = Process.Start(startInfo)
?? throw new InvalidOperationException("failed to start check-compose-socket.sh");
var stdOut = process.StandardOutput.ReadToEnd();
var stdErr = process.StandardError.ReadToEnd();
process.WaitForExit();
return (process.ExitCode, stdOut + stdErr);
var (exitCode, stdOut, stdErr) = ScriptProcess.Run(
"tools/check-compose-socket.sh", RealPath, args: ["--config-file", fixturePath]);
return (exitCode, stdOut + stdErr);
}
finally
{
Expand Down
37 changes: 8 additions & 29 deletions tests/GenWave.Host.Tests/Specs/Gh242_ComposePiperOnlyOverride.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,27 +28,19 @@
using System.Diagnostics;
using System.Text.Json;

using GenWave.Host.Tests.Support;

namespace GenWave.Host.Tests.Specs;

public static class FeatureComposePiperOnlyOverride
{
const string OverlayFile = "compose.piper-only.yaml";

static string RepoRoot()
{
var dir = new DirectoryInfo(AppContext.BaseDirectory);
while (dir is not null && !File.Exists(Path.Combine(dir.FullName, "GenWave.sln")))
dir = dir.Parent;

if (dir is null) throw new InvalidOperationException("repo root (GenWave.sln) not found");
return dir.FullName;
}

static JsonDocument RenderConfig(bool demoOverlay, bool piperOnlyOverlay)
{
var startInfo = new ProcessStartInfo("docker")
{
WorkingDirectory = RepoRoot(),
WorkingDirectory = RepoRootLocator.Find(AppContext.BaseDirectory),
RedirectStandardOutput = true,
RedirectStandardError = true,
UseShellExecute = false,
Expand Down Expand Up @@ -245,25 +237,12 @@ public static void The_demo_topology_itself_is_untouched()

public static class ScenarioLaunchScriptFlag
{
static (int ExitCode, string StdOut, string StdErr) RunLaunch(params string[] args)
{
var startInfo = new ProcessStartInfo("bash")
{
WorkingDirectory = RepoRoot(),
RedirectStandardOutput = true,
RedirectStandardError = true,
UseShellExecute = false,
};
startInfo.ArgumentList.Add(Path.Combine(RepoRoot(), "launch.sh"));
foreach (var arg in args) startInfo.ArgumentList.Add(arg);
// --dry-run only, driving the real toolchain on the developer's own PATH, not a scratch
// bin — ScriptProcess still starts the child from its sanitized environment (gh-#776).
static readonly string RealPath = Environment.GetEnvironmentVariable("PATH") ?? "/usr/bin:/bin";

using var process = Process.Start(startInfo)
?? throw new InvalidOperationException("failed to start launch.sh");
var stdOut = process.StandardOutput.ReadToEnd();
var stdErr = process.StandardError.ReadToEnd();
process.WaitForExit();
return (process.ExitCode, stdOut, stdErr);
}
static (int ExitCode, string StdOut, string StdErr) RunLaunch(params string[] args) =>
ScriptProcess.Run("launch.sh", RealPath, args: args);

static string[] PlanLines(string stdOut) =>
stdOut.Split('\n').Where(l => l.StartsWith("plan> ", StringComparison.Ordinal)).ToArray();
Expand Down
39 changes: 9 additions & 30 deletions tests/GenWave.Host.Tests/Specs/Gh310_PiperOnlyDropsTheLlm.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,25 +18,17 @@
using System.Diagnostics;
using System.Text.Json;

using GenWave.Host.Tests.Support;

namespace GenWave.Host.Tests.Specs;

public static class FeatureComposePiperOnlyDropsTheLlm
{
static string RepoRoot()
{
var dir = new DirectoryInfo(AppContext.BaseDirectory);
while (dir is not null && !File.Exists(Path.Combine(dir.FullName, "GenWave.sln")))
dir = dir.Parent;

if (dir is null) throw new InvalidOperationException("repo root (GenWave.sln) not found");
return dir.FullName;
}

static JsonDocument RenderConfig(bool demoOverlay, bool piperOnlyOverlay)
{
var startInfo = new ProcessStartInfo("docker")
{
WorkingDirectory = RepoRoot(),
WorkingDirectory = RepoRootLocator.Find(AppContext.BaseDirectory),
RedirectStandardOutput = true,
RedirectStandardError = true,
UseShellExecute = false,
Expand Down Expand Up @@ -153,25 +145,12 @@ public static void A_demo_box_without_the_overlay_still_gets_ollama()

public static class ScenarioBareComposeCommandsMatchTheLaunch
{
static string DryRunPlan(params string[] args)
{
var startInfo = new ProcessStartInfo("bash")
{
WorkingDirectory = RepoRoot(),
RedirectStandardOutput = true,
RedirectStandardError = true,
UseShellExecute = false,
};
startInfo.ArgumentList.Add(Path.Combine(RepoRoot(), "launch.sh"));
foreach (var arg in args) startInfo.ArgumentList.Add(arg);
startInfo.ArgumentList.Add("--dry-run");

using var process = Process.Start(startInfo)
?? throw new InvalidOperationException("failed to start launch.sh");
var stdOut = process.StandardOutput.ReadToEnd();
process.WaitForExit();
return stdOut;
}
// --dry-run only, driving the real toolchain on the developer's own PATH, not a scratch
// bin — ScriptProcess still starts the child from its sanitized environment (gh-#776).
static readonly string RealPath = Environment.GetEnvironmentVariable("PATH") ?? "/usr/bin:/bin";

static string DryRunPlan(params string[] args) =>
ScriptProcess.Run("launch.sh", RealPath, args: [.. args, "--dry-run"]).StdOut;

[Fact]
public static void The_appliance_flow_records_both_overlay_files()
Expand Down
Loading
Loading