[Improvement] Refator BaseVersionV2 into BaseVersion - #3973
Merged
arturcic merged 6 commits intoMar 21, 2024
Merged
Conversation
Member
|
@HHobeck please rebase the PR and I will have a look |
…have the version calculation transparent to the user.
HHobeck
force-pushed
the
feature/refactoring-base-version
branch
from
March 21, 2024 08:19
85307b4 to
58e68f1
Compare
Member
|
@HHobeck can you check these warnings https://github.com/GitTools/GitVersion/pull/3973/files#annotation_19544676058? |
arturcic
reviewed
Mar 21, 2024
arturcic
reviewed
Mar 21, 2024
arturcic
reviewed
Mar 21, 2024
arturcic
reviewed
Mar 21, 2024
arturcic
approved these changes
Mar 21, 2024
arturcic
enabled auto-merge
March 21, 2024 10:45
Contributor
|
Thank you @HHobeck for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Close #3916
Checklist: