Skip to content
This repository was archived by the owner on Mar 14, 2024. It is now read-only.

[ext] New Getting Started tutorial (extension service worker) - #5743

Merged
AmySteam merged 283 commits into
mainfrom
sw-tut
May 2, 2023
Merged

[ext] New Getting Started tutorial (extension service worker)#5743
AmySteam merged 283 commits into
mainfrom
sw-tut

Conversation

@AmySteam

@AmySteam AmySteam commented Mar 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Scope

  • Adds a new tutorial to the Getting Started guides called "Quick API reference"

TODO:

  • Finish Test that it works / Potential enhancements
  • Add links to the new explainer.
  • Merge code sample PR#851

@AmySteam AmySteam added extensions Issues related to extensions documentation. DO NOT MERGE labels Mar 21, 2023
@AmySteam AmySteam changed the title [ext] New Service worker tutorial [ext] New Getting Started tutorial with emphasis on the extension service worker Mar 21, 2023
@chrome-devrel-infra

chrome-devrel-infra Bot commented Mar 21, 2023 •
edited
Loading

Copy link
Copy Markdown

✅ Preview (static) for commit 537af7a available at https://pr-5743-static-dot-dcc-staging.uc.r.appspot.com/.

The following pages likely changed with this PR:

@AmySteam
AmySteam requested a review from sebastianbenz March 21, 2023 14:35
sebastianbenz
sebastianbenz reviewed Mar 21, 2023
View reviewed changes

@sebastianbenz sebastianbenz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, left a few in between meetings comments. Will continue later.

Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
@AmySteam AmySteam changed the title [ext] New Getting Started tutorial with emphasis on the extension service worker [ext] New Getting Started tutorial (extension service worker) Mar 21, 2023
sebastianbenz
sebastianbenz reviewed Mar 21, 2023
View reviewed changes

@sebastianbenz sebastianbenz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few more comments, only small things. Overall I think this is great!

Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
@AmySteam
AmySteam requested a review from sebastianbenz March 24, 2023 21:40
@AmySteam

AmySteam commented Mar 24, 2023

Copy link
Copy Markdown
Collaborator Author

@sebastianbenz Thanks for sharing your insights! 💯 This is ready for another round of tech review 😄

sebastianbenz
sebastianbenz reviewed Mar 29, 2023
View reviewed changes

@sebastianbenz sebastianbenz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, but looks great!

I've noticed that the videos are quite small. Does dcc support opening inline videos in a lightbox?

Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md
Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated

To continue your extension service worker learning path, we recommend exploring the following articles:

- TBD

@sebastianbenz sebastianbenz Mar 29, 2023

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you already got a list of articles to link to here?

@AmySteam AmySteam Apr 3, 2023

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping to link to some Service worker "How-to's" or the explainer, but that is only one approach.

We could also simply link our to general development articles. I'm open to suggestions.

AmySteam and others added 2 commits April 3, 2023 15:32
@AmySteam
Update available links
c6fd424
@AmySteam @sebastianbenz
Apply suggestions from tech review - p4
45f41eb 
Co-authored-by: Sebastian Benz <sebastian.benz@gmail.com>
@AmySteam
AmySteam marked this pull request as ready for review April 5, 2023 14:58
@AmySteam
AmySteam requested a review from rachelandrew April 5, 2023 14:58
rachelandrew
rachelandrew approved these changes Apr 5, 2023
View reviewed changes

@rachelandrew rachelandrew left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one small comment, I'm assuming all the TBD links will be fixed before merging.

Comment thread site/en/docs/extensions/mv3/getstarted/tut-quick-reference/index.md Outdated
@AmySteam @rachelandrew
Update site/en/docs/extensions/mv3/getstarted/tut-quick-reference/ind…
38a761d 
…ex.md

Co-authored-by: Rachel Andrew <rachelandrew@google.com>
@AmySteam

AmySteam commented Apr 5, 2023

Copy link
Copy Markdown
Collaborator Author

Thanks @rachelandrew! 💯 Yep, the links will be added when some other articles are merged.

@chrome-devrel-infra chrome-devrel-infra Bot deleted a comment from netlify Bot Apr 17, 2023
ktran and others added 27 commits April 24, 2023 15:19
@ktran @AmySteam
add vaatika as author (#6062)
024d265
@pepelsbey @AmySteam
Add active link to Squoosh (#6066)
97f7ef2
@beaufortfrancois @AmySteam
Fix author entry in feed.xml (#6064)
3ca4b1b
Joe Medley @AmySteam
Fix figure captions and links (#6068)
639ad51
Joe Medley @AmySteam
Format code in caption. (#6069)
77567f9
@kevinkiklee @AmySteam
Add FencedFrameConfig info (#6071)
a91aeb3
@joshuaali @AmySteam
Remove user index in link to Google Groups post (#6073)
2fee4e7
@primeagen-rustaceans @AmySteam
Update index.md (#6079)
2690f38 
Typo mistake corrected.
@agektmr @AmySteam
Extend SAB reverse origin trial termination (#6075)
99e2ce4
@matthiasrohmer @AmySteam
chore: update webdev-infra to 1.0.54
9e1d27b
@nancymic2 @AmySteam
Nancy fledge fix (#6081)
c5475b7 
* fix table maybe

* fix table maybe
@IanStanion-google @oliverdunk @AmySteam
Defined "offscreen document" (#6038)
ad30355 
* Defined "offscreen document"

* Moved sentence to Description

* Update index.md

* Update site/en/docs/extensions/reference/offscreen/index.md

Co-authored-by: Oliver Dunk <oliverdunk@google.com>

---------

Co-authored-by: Oliver Dunk <oliverdunk@google.com>
@nancymic2 @AmySteam
remove asterisk-not needed (#6082)
e73b05f 
left over from table
Joe Medley @AmySteam
Add new items to CWS troubleshooting. (#6084)
7c9dd23
@tropicadri @AmySteam
Fix missing link (#6086)
10e6085
Joe Medley @sebastianbenz @AmySteam
Add MV3 support blurb to selected pages. (#6085)
1155d26 
* Add MV3 support blurb to selected pages.

* Add support blurb to MV3 intro pages.

* Update site/en/_partials/extensions/mv3-support.md

Co-authored-by: Sebastian Benz <sebastian.benz@gmail.com>

---------

Co-authored-by: Sebastian Benz <sebastian.benz@gmail.com>
@ktran @sofiayem @AmySteam
Add breakpoint ux redesign blogpost (#6058)
602de0c 
* Add breakpoint ux redesign blogpost

* fix errors

* fix authors info

* fix header

* Change post layout and date

* change header after adaption by Sofia

* endAside fix

* endAside fix

* update header and footer

* remove quotes

---------

Co-authored-by: Sofia Emelianova <42939855+sofiayem@users.noreply.github.com>
@ktran @AmySteam
fix picture (#6098)
b8c61f6
@devnook @AmySteam
Fix broken links (#6097)
84b853f
@primeagen-rustaceans @AmySteam
Added links for a more consistant UI experience. (#6092)
59b2cfa 
Added LInks to Scripting and Action links.
@nancymic2 @AmySteam
add topics calls to event page (#6029)
ce76df4
@meduzen @AmySteam
Fix typo in CSS text-wrap: balanced (#6051)
6b5cb31
@nancymic2 @alexandrascript @AmySteam
Add seller guide FAQ & convert table to DL in buyer's guide (#6083)
9dfeaef 
* convert wide table

* convert table to DL and add seller guide FAQ

* Accept change  site/en/docs/privacy-sandbox/fledge-api/ad-auction/index.md

Co-authored-by: Alexandra White <alexandrawhite@google.com>

---------

Co-authored-by: Alexandra White <alexandrawhite@google.com>
@alexandrascript @AmySteam
fix url (#6100)
b0ce4d1
@primeagen-rustaceans @AaronForinton @AmySteam
Update index.md (#6091)
5827aa5 
* Update index.md

By consistantly using extension's action icon instead of extension action, thereby adding more clarity to the user.

* Update index.md

---------

Co-authored-by: Aaron Forinton <89849359+AaronForinton@users.noreply.github.com>
Joe Medley @AmySteam
Update "What's new" (#6102)
df24a89
@AmySteam
Merge branch 'main' into sw-tut
537af7a
@AmySteam
AmySteam merged commit fa2358a into main May 2, 2023
@AmySteam
AmySteam deleted the sw-tut branch May 2, 2023 14:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@sebastianbenz sebastianbenz sebastianbenz left review comments
@rachelandrew rachelandrew rachelandrew approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

extensions Issues related to extensions documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.