Skip to content
This repository was archived by the owner on Mar 14, 2024. It is now read-only.

Removes spurious references to apps from CRX docs - #791

Merged
awfuchs merged 9 commits into
mainfrom
b180055533
Jun 17, 2021
Merged

awfuchs merged 9 commits into
mainfrom
b180055533

Conversation

@awfuchs

@awfuchs awfuchs commented May 18, 2021

Copy link
Copy Markdown
Contributor

Fixes b/180055533.

Purged selected occurrences of "apps" that seem obsolete. Also removed offline_enabled page.

@netlify

netlify Bot commented May 18, 2021 •

Copy link
Copy Markdown

✔️ Deploy Preview for developer-chrome-com ready!

🔨 Explore the source changes: e91c56e

🔍 Inspect the deploy log: https://app.netlify.com/sites/developer-chrome-com/deploys/60cb632886d11b00071b52fe

😎 Browse the preview: https://deploy-preview-791--developer-chrome-com.netlify.app

@chrome-devrel-review-bot

Copy link
Copy Markdown
Collaborator

Hello! This is an automated review by our custom reviewbot. It updates automatically when code or GitHub comments in this pull request are created or updated.

Requested changes

If there are any common problems with the content files you created or modified, they will be listed here.

site/en/docs/extensions/mv3/declare_permissions/index.md

  • Please break lines at 100 characters maximum. Long lines can be difficult to work with in GitHub's pull request UI. The following tools can help speed up the process: Rewrap (VS Code), Docs To X (Google Docs; only available for Googlers). Affected lines: 14, 62, 67, 70, 71, 75, 81, 85, 89, 103, 107, 111, 115, 119, 123, 128, 133, 138, 142, 147, 151, 155, 160, 165, 170, 174, 179, 183, 187, 191, 195, 200, 205, 209, 213, 218, 222, 226, 231, 235, 243, 247, 251, 255, 259, 263, 267, 271, 275, 279, 283, 287, 291, 295, 299, 303, 307, 311, 315, 319, 323, 328, 329, 330, 335, 339, 343, 347, 349, 350, 356, 360, 364, 368, 372

site/en/docs/extensions/mv3/devtools/index.md

  • This file passed all of our automated Markdown audits.

site/en/docs/extensions/mv3/faq/index.md

  • Please change your usage of the following words:
    • Avoid please. Affected lines: 240, 268

site/en/docs/extensions/mv3/manifest/incognito/index.md

  • This file passed all of our automated Markdown audits.

site/en/docs/extensions/mv3/manifest/index.md

  • Please break lines at 100 characters maximum. Long lines can be difficult to work with in GitHub's pull request UI. The following tools can help speed up the process: Rewrap (VS Code), Docs To X (Google Docs; only available for Googlers). Affected lines: 9, 21, 22, 23, 26, 27, 28, 29, 32, 33, 34, 35, 37, 39, 40, 41, 42, 43, 44, 45, 46, 47, 48, 49, 50, 51, 52, 54, 55, 56, 57, 58, 60, 61, 62, 63, 64, 65, 66, 67, 68, 69, 70, 71, 73, 74, 75, 76, 77, 79, 80, 81, 82, 83, 84, 85, 86, 88, 89, 90, 91, 92

site/en/docs/extensions/mv3/manifest/requirements/index.md

  • This file passed all of our automated Markdown audits.

site/en/docs/extensions/mv3/manifest/sandbox/index.md

  • Please change your usage of the following words:
    • Avoid please. Affected lines: 10

site/en/docs/extensions/mv3/messaging/index.md

  • Please change your usage of the following words:
    • Do not use master. Affected lines: 344

site/en/docs/extensions/mv3/permission_warnings/index.md

  • Please break lines at 100 characters maximum. Long lines can be difficult to work with in GitHub's pull request UI. The following tools can help speed up the process: Rewrap (VS Code), Docs To X (Google Docs; only available for Googlers). Affected lines: 124, 202, 208, 214, 230, 231, 236, 246, 251, 256, 261, 267, 272, 277, 282, 287, 292, 297, 302, 307, 314, 315, 321, 326, 331

site/en/docs/extensions/mv3/richNotifications/index.md

  • Please change your usage of the following words:
    • Do not use master. Affected lines: 184

site/en/docs/extensions/mv3/sandboxingEval/index.md

  • Please change your usage of the following words:
    • Avoid please. Affected lines: 43, 51

site/en/docs/extensions/mv3/tut_analytics/index.md

  • Please change your usage of the following words:
    • Avoid please. Affected lines: 17
    • Do not use master. Affected lines: 158

site/en/docs/extensions/mv3/xhr/index.md

  • This file passed all of our automated Markdown audits.

@pullapprove
pullapprove Bot requested a review from dotproto May 18, 2021 00:47
@awfuchs
awfuchs requested review from rdcronin and removed request for dotproto May 18, 2021 00:47
@pullapprove
pullapprove Bot requested a review from dotproto May 18, 2021 00:47

@dotproto dotproto left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits asside, LGTM

Comment thread site/en/docs/extensions/mv3/declare_permissions/index.md Outdated
Comment thread site/en/docs/extensions/mv3/manifest/index.md

@rdcronin rdcronin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Andy!

Comment thread site/en/docs/extensions/mv3/declare_permissions/index.md Outdated
Comment thread site/en/docs/extensions/mv3/declare_permissions/index.md Outdated
Comment thread site/en/docs/extensions/mv3/manifest/incognito/index.md Outdated
Comment thread site/en/docs/extensions/mv3/manifest/index.md
Comment thread site/en/docs/extensions/mv3/manifest/sandbox/index.md Outdated
Comment thread site/en/docs/extensions/mv3/permission_warnings/index.md
Comment thread site/en/docs/extensions/mv3/tut_analytics/index.md
Co-authored-by: rdcronin <rdcronin@users.noreply.github.com>
@google-cla google-cla Bot added the cla: yes label Jun 15, 2021
@awfuchs
awfuchs requested a review from rdcronin June 15, 2021 14:58

@rdcronin rdcronin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits. Thanks, Andy!

Comment thread site/en/docs/extensions/mv3/declare_permissions/index.md Outdated
Comment on lines +23 to +24
The `"split"` mode means that all
pages in an incognito window will run in their own incognito process. If the extension

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: fix wrapping through here

Comment thread site/en/docs/extensions/mv3/tut_analytics/index.md Outdated
Comment thread site/en/docs/extensions/mv3/xhr/index.md Outdated
awfuchs and others added 3 commits June 17, 2021 07:49
Co-authored-by: rdcronin <rdcronin@users.noreply.github.com>
Co-authored-by: rdcronin <rdcronin@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants