Skip to content

MediaError.message Sample's invalid file case is cross-origin; message is cleared as a result #664

Closed

Description

@wolenetz

In M68, Chromium included a change (https://chromium-review.googlesource.com/c/chromium/src/+/1015794/) that clears the error message before exposing it to JS via a MediaError, in the case where the media "should be opaque". This opacity condition is satisfied by the Sample (because no_streams.webm is cross-origin), so that case now just emits an error with an empty message.

This issue tracks updating the sample in one or both of the following ways:

  1. Explicitly note that the cross-origin no_streams.webm / invalid file case is not expected to produce an error message.
  2. Include an invalid file case where the resource is not cross-origin, and the error message is still populated and exposed in current Chrome.

@beaufortfrancois - please triage and let me know if you have any questions.
See also https://crbug.com/1012728 where this Sample's change in behavior around the invalid file case was reported.

Activity

  1. beaufortfrancois commented on Nov 28, 2019

    @beaufortfrancois
    Member

    @wolenetz Thanks for catching this issue.

    If #665 looks good you, I'll merge and close this issue.

  2. wolenetz commented on Dec 2, 2019

    @wolenetz
    Author

    #665 LGTM. Thank you.

  3. beaufortfrancois commented on Dec 4, 2019

    @beaufortfrancois
    Member
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions