Fix(pubsub): Upgrade Cloud Functions Pub/Sub to Java25#10279
Open
Kef131 wants to merge 2 commits into
Open
Conversation
…25, and add JaCoCo test coverage plugin
product-auto-label
Bot
added
api: pubsub
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the parent POM version, adds the JaCoCo Maven plugin for test coverage reporting, and upgrades the Java compiler target and source versions. The reviewer noted that the Java compiler properties should be set directly to Java 25 to align with the pull request's objective, rather than using Java 21 with a temporary comment.
Kef131
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
LGTM! |
product-auto-label
Bot
removed
the
api: cloudfunctions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #
b/470272226
Upgrades the Cloud Functions Pub/Sub Publish Message sample to Java 25:
maven.compiler.sourceandmaven.compiler.targetto25.shared-configurationparent version to1.2.2.jacoco-maven-pluginto0.8.14to support Java 25 (Class file major version 69). - Configuresjacoco-maven-pluginexecutions (prepare-agentandreport) to enable dynamic bytecode instrumentation for test coverage collection and report generation during the test lifecycle as mentioned on bug.Checklist
pom.xmlparent set to latestshared-configuration(1.2.2)mvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only (Note: ErrorProne 2.18.0 and Spotbugs 4.7.3.3 from parent pom have compatibility warnings/errors under Java 25)