Skip to content

Handle undo add to resource. #49

Description

@JohanLarsson

We need to undo the edit of the resx file and the generated file.

Activity

  1. CyrusNajmabadi commented on Apr 20, 2018

    @CyrusNajmabadi

    Take a look at https://github.com/dotnet/roslyn/blob/master/src/VisualStudio/Core/Def/Packaging/PackageInstallerServiceFactory_UndoRedo.cs for how we do this in roslyn for uninstalling a nuget package on 'undo' if you install it with the lightbulb.

  2. JohanLarsson commented on Apr 20, 2018

    @JohanLarsson
    MemberAuthor

    Would adding the resx as an additional document and then do text.WithChanges(...) enable undo?
    Guess I can try it.
    Alternatively split it up in two code actions, one that adds and one that does the text.WithChanges(...)
    Also not sure if it will lead to other bs but guessing the sln is reparsed so that it does not matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions