Repository navigation
fix(hardened): the sync agent runs the fork's own tests before handing off - #36
Open
hyrmedia-hector wants to merge 1 commit into
Open
hyrmedia-hector wants to merge 1 commit into
hyrmedia-hector wants to merge 1 commit into
Conversation
…g off The daily sync failed at Land after CI on Nov 11 and Nov 12 because CI failed on the agent's merge: upstream changes broke fork tests in files that merged without a conflict (UsageService.test.ts, provider-opencode usage.test.ts). The agent only ran the tests beside the files it edited, so it never saw them. resolve-sync.sh now lists the test files the fork added or changed since the last upstream commit it merged, and the prompt has the agent run them all. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Other scenariosAll 64 scenario measurements match All 64 scenario measurements
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Hardened Daily Release failed at Resolve conflicts / Land after CI on Nov 11 (run 43066852559) and Nov 12 (run 43236636479). Both times the land job opened the sync PR (#32, #35), then stopped with
CI failed. Finish the merge in .... CI failed on the agent's merge because upstream changes broke fork tests in files that merged without a conflict:apps/server/src/usage/UsageService.test.ts> "counts unpriced tokens from the unpriced records of a mixed model" failed withdatabase is not open. It was fixed by hand in 9a74705.packages/provider-opencode/src/server/usage.test.ts> "counts migrated OpenCode messages once and sees subsequent WAL writes" failed. Test Web also failed that day when the browser test connection closed.The resolve agent only runs the tests beside the files it edits, so it never ran these.
Change
resolve-sync.shlists the test files the fork added or changed since the last upstream commit it merged (git diff --diff-filter=AM $(git merge-base HEAD upstream/main) HEAD, browser tests left out because this job installs no Chromium). It appends that list to the prompt as "Fork tests". The prompt has the agent run all of them from their owning packages, fix what the merge broke, and report which still fail.Scope
Fork-only change to the hardened sync tooling in
.github/hardened/. It changes no app code and no workflow file. A browser-test flake like Nov 11's Test Web failure still fails the land step.Verification
bash -n .github/hardened/resolve-sync.shpasses.apps/server/src/usage/UsageService.test.tsandpackages/provider-opencode/src/server/usage.test.ts.Claude Opus 5.5 via Claude Code.
Generated by Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.