Repository navigation
Add Korean (ko) locale - #818
Open
jamie-dongjae wants to merge 1 commit into
Open
jamie-dongjae wants to merge 1 commit into
jamie-dongjae wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Adds a Korean (
ko) locale:src/renderer/src/i18n/locales/ko.jsonwith all 1170 strings ofen.jsontranslated, and thekoentry registered insrc/renderer/src/i18n/index.ts(resources,supportedLngs, and the language list, labelled 한국어). Korean-speaking users currently get the English fallback; with this change they can pick 한국어 in Settings → General → Language and the whole interface follows.The key set is identical to
en.jsonand every interpolation placeholder ({{count}},{{name}}, …) is kept as inen.json, both checked by script. Product names, commands and model ids (Claude Code, Codex,/skill, …) stay in English, as in the other locales.How the translation was made, so reviewers know what they are looking at: the strings were machine-translated in 40-string batches with a language model, each batch validated by script (keys, placeholders, no untranslated leftovers), then spot-read in the running app (Settings, Command Center, the agent bar, see the screenshot). A native speaker's pass over the whole file is welcome; corrections are easy to send as follow-ups.
Type of change
Evidence
Both shots: the same scratch config, window 1440×900, Settings → General scrolled to the Language row. The images live on the
i18n-ko-evidencebranch of my fork.Before
main: the Language list offers English, 简体中文 and العربية only; a Korean user sees the English interface.After
This branch with 한국어 selected: the language list has 한국어 and Settings, the Command Center tabs and the agent bar are rendered in Korean.
Checks
npm run typecheck: greennpm run test:focused: one failure, the Codex model-list expectation, which fails the same way onmainwithout this changenpm run build: greenAgent review
I ran a coding agent over the diff with the questions from CONTRIBUTING. Cross-platform behaviour, paths with spaces and provider neutrality: nothing to flag, the change is a JSON file plus four lines registering it, no paths or provider strings. Performance: the locale is bundled eagerly like the existing ones (about 90 KB more renderer bundle), nothing in a hot path. Security: static strings only. Flagged and left as is: the pixel display font has no Hangul glyphs, so headings such as the Settings navigation fall back to the system font at a small size (visible in the After shot); the existing 简体中文 locale behaves the same way, and a font change would be a separate PR.