Skip to content

fix(git): support SSH git@ style URLs and fix tag checkout issues (issues #170, #129)#251

Merged
snakeice merged 2 commits into
HashLoad:mainfrom
isaquepinheiro:bugfix/issue-170-ssh-parsing
Jul 16, 2026
Merged

fix(git): support SSH git@ style URLs and fix tag checkout issues (issues #170, #129)#251
snakeice merged 2 commits into
HashLoad:mainfrom
isaquepinheiro:bugfix/issue-170-ssh-parsing

Conversation

@isaquepinheiro

Copy link
Copy Markdown
Contributor

This PR enhances the Git remote URL parsing regex to support standard SSH git@github.com style paths and resolves conflicts with version tag parsing during SSH checkouts.

@HashLoad HashLoad deleted a comment from codecov-commenter Jul 7, 2026
… line

golangci-lint: revive var-naming, lll line >120 chars
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 87.50000% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@0f2a917). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/core/domain/dependency.go 0.00% 1 Missing and 1 partial ⚠️
internal/core/services/installer/utils.go 93.33% 1 Missing and 1 partial ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #251   +/-   ##
=======================================
  Coverage        ?   25.76%           
=======================================
  Files           ?       82           
  Lines           ?     3865           
  Branches        ?        0           
=======================================
  Hits            ?      996           
  Misses          ?     2793           
  Partials        ?       76           
Flag Coverage Δ
unittests 25.76% <87.50%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@snakeice

Copy link
Copy Markdown
Member

Rebased on main. CI retriggering...

@snakeice
snakeice merged commit 7dbb8a0 into HashLoad:main Jul 16, 2026
3 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants