Add Node.js inspector (+ inspector/promises) externs - #218
Merged
Merged
Conversation
Cover the stable module surface (open/close/url/waitForDebugger/console/Session) plus pragmatic Network, NetworkResources, and DOMStorage helpers without exhaustive CDP typings. Co-authored-by: Cursor <cursoragent@cursor.com>
Align SessionEvent.DebuggerResumed with notification message handlers, document webSocket*/DomStorage as Node 24-only, and clarify Disposable open() / promises SessionEvent reuse. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
js.node.Inspectorfor the stableinspectormodule:open/close/url/waitForDebugger/consolejs.node.inspector.Session(EventEmitter subclass) with typed session events where practical and callback-basedpostNetwork,NetworkResources,DomStorage(experimental Node flags), without exhaustive CDP schema typingsjs.node.InspectorPromises+js.node.inspector.promises.Sessionfor Promise-returningpostTest plan
haxe build.hxml(Haxe 5.0.0-preview.1) — passes (pre-existing Url/Domain warnings only)Session.connect/postagainst Node 24 inspector callback APIinspector/promisesSessionpostreturns a PromiseNetwork.requestWillBeSentparam typedefs against Node docs examplesMade with Cursor