Audit networking externs for Node 24 + Haxe 4 - #226
Merged
Merged
Conversation
Fill net/http/https/http2/tls/dgram/dns/tty API gaps against Node 24, replace Haxe 3 conditionals with Haxe 4 types, and tighten Dynamics where practical. Co-authored-by: Cursor <cursoragent@cursor.com>
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#if haxe4/haxe_ver/js.htmlfallbacks in these modules; keeps Haxe 4.0.5-safe arrow/js.libtyping.Class<Dynamic>/ bareDynamicusages with concrete types orAny, and documents remaining certificate / WebSocket TODOs.Test plan
haxe build.hxml(ImportAll) succeeds for changed networking moduleshttp/net/tls/dnsstill typecheckRemaining TODOs
TODO(section-3): expandPeerCertificatefield set; typegetPeerX509Certificate/getX509Certificateagainst cryptoX509CertificateTODO(section-3): remove deprecatedHttp2Stream.priorityonce callers migrateTODO(section-6): preferjs.node.webWebSocket typing forhttp.WebSocketMade with Cursor