Wire Assert, TextEncoder, and MessagePort transfer typing - #234
Merged
kevinresol merged 21 commits intoJul 14, 2026
Merged
kevinresol merged 21 commits into
kevinresol merged 21 commits into
Conversation
Add missing Node 24 fs/zlib APIs (openAsBlob, mkdtempDisposable*, Zstd), drop Haxe 3 conditionals in this section, and tighten Dynamic where possible. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop remaining Haxe 3 conditionals, prefer js.node.web.AbortSignal, and add core node:trace_events, node:sqlite, and node:sea surfaces. Co-authored-by: Cursor <cursoragent@cursor.com>
Add StatWatcher/Utf8Stream, Fs.promises, F_OK deprecations, glob URL cwd, FSWatcher ref/unref, Zlib options polish, and PathModule.toNamespacedPath. Co-authored-by: Cursor <cursoragent@cursor.com>
Fill net/http/https/http2/tls/dgram/dns/tty API gaps against Node 24, replace Haxe 3 conditionals with Haxe 4 types, and tighten Dynamics where practical. Co-authored-by: Cursor <cursoragent@cursor.com>
Align child_process, cluster, readline, repl, vm, v8, and domain with Node 24 APIs, drop Haxe 3 conditionals, and add core async_hooks, worker_threads, and wasi stubs. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop Haxe 3 conditionals across events, stream, buffer, timers, process, module, and globals; add missing Node 24 public APIs; tighten Dynamics where types exist; leave cross-section TODOs for web streams and IPC/loader types. Co-authored-by: Cursor <cursoragent@cursor.com>
Fix registerStorage options shape, expose DatabaseSync open/txn/limits, tighten Network headers typing, and clean MockTracker formatting. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop Haxe 3 conditionals, add missing Node 24 APIs (KeyObject, X509, MIMEType, CallTracker, URLPattern, argon2/KEM, parseArgs, etc.), and narrow avoidable Dynamic usage with remaining gaps marked TODO(section-4). Co-authored-by: Cursor <cursoragent@cursor.com>
Drop Haxe 3 import gates, tighten Dynamic/Any typing for fetch/abort/events, and add missing Node 24 web-platform externs (streams, messaging, WebSocket, EventSource, Navigator/locks, Storage, encoding globals). Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…cross-wiring-assert-encoder-port
…ross-wiring-assert-encoder-port
…s-wiring-assert-encoder-port
…s-wiring-assert-encoder-port
…re/cross-wiring-assert-encoder-port
…-wiring-assert-encoder-port
…-wiring-assert-encoder-port
Compose TestContextAssert with shared AssertMethods, align util.TextEncoder encodeInto with the web surface, and tighten worker/web transfer lists to real Transferable types. Co-authored-by: Cursor <cursoragent@cursor.com>
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestContextAssertextends sharedjs.node.assert.AssertMethods(instance signatures matchingjs.node.Assert); removesimplements Dynamic.Assert.strictis typed asAssertMethods.js.node.util.TextEncoderwith the web encoder surface by addingencodeIntoand reusingTextEncoderEncodeIntoResult.worker_threads.Transferablefrom already-externed types (ArrayBuffer,MessagePort,AbortSignal,FileHandle, web streams) and use it for MessagePort/Worker/postMessageToThreadtransfer lists; tighten webMessagePorttransfer similarly. Posted message values remainDynamicon purpose.Test plan
haxe build.hxmlsucceedst.assert.ok/t.assert.strictEqual/t.assert.snapshottypingutil.TextEncoder.encodeIntoandweb.TextEncoder.encodeIntopostMessage(..., transferList)acceptsArrayBuffer/MessagePortwithout inventing extra transferablesMade with Cursor