Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 25 additions & 10 deletions Scripts/ShapeEditor/Decomposition/PolyBoolCS/PolyboolExtensions.cs
Original file line number Diff line number Diff line change
Expand Up @@ -41,13 +41,14 @@ public static List<Polygon> ToPolygons(this PolyboolPolygon poly, PolyBool polyB
{
// make sure out polygon is clean
poly = polyBool.polygon(polyBool.segments(poly));
var simpleRegions = SingularRegionSplitter.Split(poly.regions);

var roots = newNode(null);

// add all regions to the root
for (var i = 0; i < poly.regions.Count; i++)
for (var i = 0; i < simpleRegions.Count; i++)
{
var region = poly.regions[i];
var region = simpleRegions[i];
if (region.Count < 3) // regions must have at least 3 points (sanity check)
continue;
addChild(roots, region);
Expand Down Expand Up @@ -83,13 +84,27 @@ public static List<Polygon> ToPolygons(this PolyboolPolygon poly, PolyBool polyB
// test if r1 is inside r2
private static bool regionInsideRegion(Region r1, Region r2)
{
// we're guaranteed no lines intersect (because the polygon is clean), but a vertex
// could be on the edge -- so we just average pt[0] and pt[1] to produce a point on the
// edge of the first line, which cannot be on an edge
return Epsilon.pointInsideRegion(new Point(
(r1[0].x + r1[1].x) * 0.5,
(r1[0].y + r1[1].y) * 0.5
), r2);
for (int i = 0; i < r1.Count; i++)
{
var next = r1[(i + 1) % r1.Count];
var midpoint = new Point((r1[i].x + next.x) * 0.5, (r1[i].y + next.y) * 0.5);
if (!PointOnBoundary(midpoint, r2))
return Epsilon.pointInsideRegion(midpoint, r2);
}
return false;
}

private static bool PointOnBoundary(Point point, Region region)
{
for (int i = 0; i < region.Count; i++)
{
var a = region[i];
var b = region[(i + 1) % region.Count];
if (Epsilon.pointsSame(point, a) ||
(Epsilon.pointsCollinear(a, b, point) && Epsilon.pointBetween(point, a, b)))
return true;
}
return false;
}

// calculate inside hierarchy
Expand Down Expand Up @@ -187,4 +202,4 @@ private static Region getInterior(MyNode node, List<Region> polygons)
}
}

#endif
#endif
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
#if UNITY_EDITOR
using System.Collections.Generic;

namespace AeternumGames.ShapeEditor.PolyBoolCS
{
internal static class SingularRegionSplitter
{
internal static List<PointList> Split(List<PointList> regions)
{
var result = new List<PointList>();
foreach (var region in regions)
{
var boundary = InsertContacts(region);
var path = new PointList();
for (int i = 0; i <= boundary.Count && boundary.Count > 0; i++)
{
var point = boundary[i % boundary.Count];
var previous = FindPoint(path, point);
if (previous < 0)
{
path.Add(point);
continue;
}

var loop = new PointList();
for (int j = previous; j < path.Count; j++)
loop.Add(path[j]);
if (loop.Count >= 3)
result.Add(loop);
path.RemoveRange(previous + 1, path.Count - previous - 1);
}
}
return result;
}

private static PointList InsertContacts(PointList region)
{
var boundary = new PointList();
for (int i = 0; i < region.Count; i++)
{
var left = region[i];
var right = region[(i + 1) % region.Count];
if (Epsilon.pointsSame(left, right))
continue;
boundary.Add(left);
var contacts = new PointList();
for (int j = 0; j < region.Count; j++)
{
var candidate = region[j];
if (Epsilon.pointsCollinear(left, right, candidate) &&
Epsilon.pointBetween(candidate, left, right) &&
FindPoint(contacts, candidate) < 0)
contacts.Add(candidate);
}
contacts.Sort((a, b) => DistanceSquared(left, a).CompareTo(DistanceSquared(left, b)));
boundary.AddRange(contacts);
}
return boundary;
}

private static int FindPoint(PointList points, Point candidate)
{
for (int i = 0; i < points.Count; i++)
if (Epsilon.pointsSame(points[i], candidate))
return i;
return -1;
}

private static double DistanceSquared(Point a, Point b)
{
var x = a.x - b.x;
var y = a.y - b.y;
return x * x + y * y;
}
}
}
#endif

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Tests~/Fixtures/Crash.s2d
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"version":2,"shapes":[{"segments":[{"_position":{"x":-0.5,"y":-0.5},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":0.0,"y":-0.5},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":-0.5,"y":0.0},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}}],"booleanOperator":0,"symmetryAxes":0},{"segments":[{"_position":{"x":0.0,"y":-0.5},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":0.5,"y":-0.5},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":0.5,"y":0.0},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}}],"booleanOperator":0,"symmetryAxes":0},{"segments":[{"_position":{"x":0.5,"y":0.0},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":0.5,"y":0.5},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":0.0,"y":0.5},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}}],"booleanOperator":0,"symmetryAxes":0},{"segments":[{"_position":{"x":-0.5,"y":0.0},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":0.0,"y":0.5},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":-0.5,"y":0.5},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}}],"booleanOperator":0,"symmetryAxes":0}],"globalPivot":{"_position":{"x":0.0,"y":0.0}}}
1 change: 1 addition & 0 deletions Tests~/Fixtures/Crash2.s2d
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{"version":2,"shapes":[{"segments":[{"_position":{"x":-0.5,"y":-0.5},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":0.0,"y":-0.5},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":-0.5,"y":0.0},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}}],"booleanOperator":0,"symmetryAxes":0},{"segments":[{"_position":{"x":0.0,"y":-0.5},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":0.5,"y":-0.5},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":0.5,"y":0.0},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}}],"booleanOperator":0,"symmetryAxes":0},{"segments":[{"_position":{"x":0.5,"y":0.0},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":0.5,"y":0.5},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":0.0,"y":0.5},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}}],"booleanOperator":0,"symmetryAxes":0},{"segments":[{"_position":{"x":-0.5,"y":0.0},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":0.0,"y":0.5},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":-0.5,"y":0.5},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}}],"booleanOperator":0,"symmetryAxes":0},{"segments":[{"_position":{"x":0.75,"y":0.25},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":1.125,"y":0.75},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":1.25,"y":0.25},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":0.75,"y":0.625},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}}],"booleanOperator":0,"symmetryAxes":0},{"segments":[{"_position":{"x":0.5,"y":-1.75},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":1.5,"y":-1.75},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":1.5,"y":-0.75},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":0.5,"y":-0.75},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}}],"booleanOperator":0,"symmetryAxes":0},{"segments":[{"_position":{"x":0.8749999403953552,"y":-1.375},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":1.125,"y":-1.375},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":1.125,"y":-1.125},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}},{"_position":{"x":0.8749999403953552,"y":-1.125},"generator":{"bezierDetail":8,"bezierGridSnapSize":0.0,"bezierPivot1":{"_position":{"x":0.0,"y":0.0}},"bezierPivot2":{"_position":{"x":0.0,"y":0.0}},"repeatSegments":2,"repeatTimes":4,"sineDetail":64,"sineFrequency":-3.5,"sineGridSnapSize":0.0,"sinePivot1":{"_position":{"x":0.0,"y":0.0}},"type":0}}],"booleanOperator":1,"symmetryAxes":0}],"globalPivot":{"_position":{"x":0.0,"y":0.0}}}
Loading