Perl 5 implementation by fedirsmilianets · Pull Request #4 · HowProgrammingWorks/Function

fedirsmilianets · 2017-06-08T22:12:44Z

there is always more than one way to do it.

Somewhere perl lacks functionality, so i try to propose (readable) analogues.

aqrln · 2017-06-08T23:52:07Z

Oh gosh... Perl. I don't even know who can review this.

aqrln · 2017-06-08T23:52:41Z

+}
+# everytime shift is called inside a function without array passed to shift operator
+# it returns next argument
+# note that shift is an operator, so it thinks of things next to it as of its arguments


Can you please wrap the comment at 80 characters?

aqrln · 2017-06-08T23:53:57Z

+sub inc1 {
+	return 1 + shift;
+}
+# everytime shift is called inside a function without array passed to shift operator


I believe it is better to have these comments above the corresponding functions, not below them.

aqrln · 2017-06-08T23:54:55Z

+print inc2(2); # returns 3
+print inc3(2); # returns 2 (look in comments near function definition)
+print sum(1, 2); # returns 3
+#print sum(1, 2, 3); # produces an error. Uncomment and try it!


I'd find it prettier to have a space after the hash.

aqrln · 2017-06-08T23:56:24Z

+
+use strict;
+# in original repo this file is named "context"
+# i take the responsibility to rename it to "scopes"


+1 on this. Mind sending a PR to change it throughout the whole repo? I'd be in support for it.

Yup, it's a good idea.

aqrln · 2017-06-08T23:58:53Z

+
+my @cities = ("Athens", "Roma", "London", "Beijing", "Kiev", "Riga");
+
+my $f = sub {return scalar @_;};


I find it more readable to have extra surrounding spaces inside the braces, but feel free to ignore this comment if the current style is idiomatic in Perl.

aqrln · 2017-06-09T00:00:49Z

+orDef(1, 2);
+orDef(1);
+orDef(1, 0);
+


aqrln · 2017-06-09T00:01:17Z

@@ -0,0 +1,4 @@
+#!/usr/bin/perl
+
+print "Actually, perl cant introspect functions :(\n";


So... I'd say we don't need this file at all, right?

So... I'd say we don't need this file at all, right?

This comment is still unaddressed.

aqrln · 2017-06-09T00:01:58Z

+use Data::Dumper;
+# spread operator is not needed in perl
+# because only way for us to get our params is through array
+# but i'll show how to iterate through params


Maybe you should change the filename in this case.

Maybe you should change the filename in this case.

This comment is still unaddressed.

aqrln · 2017-06-09T00:03:47Z

+	return $a + $b;
+}
+
+# declarement of package is between package statements.


s/declarement/declaration

aqrln · 2017-06-09T00:07:46Z

+
+use strict;
+use Data::Dumper;
+# i take the responsibility to rename this chapter too


Don't worry about renaming. These files are not meant to copy the extract structure of the JavaScript samples. To the contrary, I find it detrimental that most people are doing exactly that thing instead of writing pieces of idiomatic code in a given language from scratch.

fedirsmilianets · 2017-06-09T18:22:52Z

I hope now it's ready.

aqrln · 2017-06-09T20:07:06Z

+use strict;
+use v5.10;
+
+# everytime shift is called inside a function without array passed to shift operator


Please wrap the line at 80 characters.

aqrln · 2017-06-09T20:07:13Z

+
+# everytime shift is called inside a function without array passed to shift operator
+# it returns next argument
+# note that shift is an operator, so it thinks of things next to it as of its arguments


aqrln · 2017-06-09T20:08:10Z

+use strict;
+use v5.10;
+
+


Redundant empty line.

aqrln · 2017-06-09T20:10:53Z

@@ -0,0 +1,4 @@
+#!/usr/bin/perl
+
+print "Actually, perl cant introspect functions :(\n";


So... I'd say we don't need this file at all, right?

This comment is still unaddressed.

aqrln · 2017-06-09T20:10:57Z

+#!/usr/bin/perl
+
+print "Actually, perl cant introspect functions :(\n";
+


A superfluous empty line. The text files in Unix are supposed to have one empty line at the end, not two of them :)

This comment is still unaddressed.

aqrln · 2017-06-09T20:11:13Z

+use Data::Dumper;
+# spread operator is not needed in perl
+# because only way for us to get our params is through array
+# but i'll show how to iterate through params


Maybe you should change the filename in this case.

This comment is still unaddressed.

aqrln · 2017-06-10T21:38:21Z

+# everytime shift is called inside a function without array passed to it
 # it returns next argument
-# note that shift is an operator, so it thinks of things next to it as of its arguments
+# note that shift is a fucntion that awaits arguments


s/fucntion/function

aqrln · 2017-06-10T21:39:25Z

@@ -1,4 +0,0 @@
-#!/usr/bin/perl


Can you please update the names of the other files so that there are no gaps in the ordering?

fedirsmilianets added 4 commits June 8, 2017 20:04

Adds perl 5 implementation of first 3 examples

3c17571

Completes 1

79930ea

Adds some more examples and modifies 1 to show correct argument syntax

2950c6e

Adds lacking chapters

d41560c

aqrln reviewed Jun 9, 2017

View reviewed changes

Fixes style mistakes, switches to say, adds lvalue example

325af91

aqrln reviewed Jun 9, 2017

View reviewed changes

Deletes unneeded files, corrects more mistakes

c85e8b1

aqrln reviewed Jun 10, 2017

View reviewed changes

Fixes typos, moves examples to fill the gap

7af4c2d

tshemsedinov force-pushed the master branch from 495ce31 to 90728b6 Compare September 11, 2017 12:12

tshemsedinov force-pushed the master branch from 516d3a6 to a2f04c4 Compare October 15, 2019 11:28


		my @cities = ("Athens", "Roma", "London", "Beijing", "Kiev", "Riga");

		my $f = sub {return scalar @_;};

		@@ -0,0 +1,4 @@
		#!/usr/bin/perl

		print "Actually, perl cant introspect functions :(\n";

		use strict;
		use v5.10;

Uh oh!

Uh oh!

Conversation

fedirsmilianets commented Jun 8, 2017

Uh oh!

aqrln commented Jun 8, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aqrln Jun 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aqrln Jun 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fedirsmilianets commented Jun 9, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aqrln Jun 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aqrln Jun 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aqrln Jun 9, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aqrln Jun 9, 2017 •

edited

Loading

aqrln Jun 9, 2017 •

edited

Loading

aqrln Jun 9, 2017 •

edited

Loading

aqrln Jun 9, 2017 •

edited

Loading

aqrln Jun 9, 2017 •

edited

Loading