C# - #2
Open
Beard777 wants to merge 3 commits into
Open
Conversation
Raixur
reviewed
Jun 6, 2017
Raixur
left a comment
Raixur
left a comment
There was a problem hiding this comment.
Doesn't look like C# at all!
Critical errors:
- Function signature must have return type or return void.
- Classes with same name in global namespace won't compile.
- No
usingdirectives.
Improvements:
- No
Enumerable.Select()example (js -map). - No foreach lambda expression example.
Codestyle:
- Class and function names shouldn't be uppercase, PascalCase is preferred.
| { | ||
| const bool flag = true; | ||
| Console.WriteLine("Hello"); | ||
| if (flag) break; |
There was a problem hiding this comment.
break must be used inside the loop, otherwise it won't compile and don't make sense.
| { | ||
| const bool flag = true; | ||
| Console.WriteLine("Hello"); | ||
| if (flag) continue; |
There was a problem hiding this comment.
continue must be used inside the loop, otherwise it won't compile and don't make sense.
| { | ||
| public FOR() | ||
| { | ||
| for (let i = 0; i < 10; i++) |
There was a problem hiding this comment.
let is used for LINQ not for simple variable initialization, use var instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Создал все виды итераций на языке C#.