Skip to content

feat!: add rental monitoring opt-out and follow the extend-reserved rename - #11

Merged
cristhian-castaneda merged 3 commits into
mainfrom
feat/monitoring-opt-out
Nov 17, 2026
Merged

cristhian-castaneda merged 3 commits into
mainfrom
feat/monitoring-opt-out

Conversation

@cristhian-castaneda

@cristhian-castaneda cristhian-castaneda commented Oct 29, 2026 •

Copy link
Copy Markdown
Member

Caution

Breaking change. ExtendReservedRentalParams.ExpectedReservedUntil is now CurrentReservedUntil, because the API renamed the field. Callers rename the field and keep the value, the extension quote's top-level reservedUntil. v0.1.0 sends the old name, which the spec no longer accepts.

Syncs the published spec and names its new operation, so the SDK regenerates. Supersedes #8, which stops at generation because ondemand-setRentalMonitoringOptOut has no name in sdk.yaml.

What's new:

  • Rentals.SetMonitoringOptOut opts a virtual machine rental in or out of Hyperbolic telemetry. It's marked idempotent, so transient failures are retried, because the spec says a failed update is safe to retry. Its rentalId is a string, through the same overlay pair as the other rental operations.
  • CreateRentalParams.MonitoringOptOut opts out at creation, and RentalWithStatus.MonitoringOptOut reports the setting.
  • GetReservedConversionQuoteParams.TermPeriodDays and ReservedConversionQuote.RequestedOption quote a conversion for a specific term length.

gorelease reports the rename as the one incompatible change, next to seven additions, and suggests v0.2.0.

The breaking-api-change label covers both checks. Besides the rename, the API changes check flags changes that leave the Go API as it is:

  • Reservations now last at most 30 days instead of 90, on every termPeriodDays. Only doc comments change.
  • Regions jp-east-2 and sim-1 were added, which also accounts for the union entries on rental options. region is a plain string in Go. openapi/README.md now says this where it lists what to look for in a spec sync.
  • On convert-to-reserved, exclusiveMinimum: 0 became minimum: 1, the same bound for an integer.

Most of the info entries come from nullable fields rewritten from anyOf [X, null] to type: [X, null]. Both mean the same, and the generated types don't change.

No new dependencies.

@cristhian-castaneda cristhian-castaneda added the breaking-api-change Breaks the API for existing users. Listed first in the release notes label Oct 29, 2026
@cristhian-castaneda cristhian-castaneda changed the title feat: add rental monitoring opt-out feat!: add rental monitoring opt-out and follow the extend-reserved rename Nov 6, 2026
@cristhian-castaneda
cristhian-castaneda merged commit c3a83e6 into main Nov 17, 2026
7 checks passed
@cristhian-castaneda
cristhian-castaneda deleted the feat/monitoring-opt-out branch November 17, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking-api-change Breaks the API for existing users. Listed first in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants