Repository navigation
feat!: add rental monitoring opt-out and follow the extend-reserved rename - #11
Merged
Merged
Conversation
zachsmith1
approved these changes
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caution
Breaking change.
ExtendReservedRentalParams.ExpectedReservedUntilis nowCurrentReservedUntil, because the API renamed the field. Callers rename the field and keep the value, the extension quote's top-levelreservedUntil. v0.1.0 sends the old name, which the spec no longer accepts.Syncs the published spec and names its new operation, so the SDK regenerates. Supersedes #8, which stops at generation because
ondemand-setRentalMonitoringOptOuthas no name insdk.yaml.What's new:
Rentals.SetMonitoringOptOutopts a virtual machine rental in or out of Hyperbolic telemetry. It's marked idempotent, so transient failures are retried, because the spec says a failed update is safe to retry. ItsrentalIdis a string, through the same overlay pair as the other rental operations.CreateRentalParams.MonitoringOptOutopts out at creation, andRentalWithStatus.MonitoringOptOutreports the setting.GetReservedConversionQuoteParams.TermPeriodDaysandReservedConversionQuote.RequestedOptionquote a conversion for a specific term length.gorelease reports the rename as the one incompatible change, next to seven additions, and suggests v0.2.0.
The
breaking-api-changelabel covers both checks. Besides the rename, the API changes check flags changes that leave the Go API as it is:termPeriodDays. Only doc comments change.jp-east-2andsim-1were added, which also accounts for the union entries on rental options.regionis a plain string in Go.openapi/README.mdnow says this where it lists what to look for in a spec sync.exclusiveMinimum: 0becameminimum: 1, the same bound for an integer.Most of the info entries come from nullable fields rewritten from
anyOf [X, null]totype: [X, null]. Both mean the same, and the generated types don't change.No new dependencies.