Use .tool-versions variables in getting-started prerequisites - #760
Merged
Conversation
Replace hardcoded versions in the Getting Started prerequisites with
{{RUST_VERSION}}, {{NODEJS_VERSION}}, and {{FASTLY_VERSION}} placeholders,
which the VitePress config substitutes from .tool-versions at build time.
Adds NodeJS as an explicit prerequisite so contributors install Node/npm
before the JS build runs.
Supersedes #758. Fixes #747.
14 tasks
ChristianPavilonis
left a comment
ChristianPavilonis
left a comment
Collaborator
There was a problem hiding this comment.
Automated Yesman review: I reviewed PR #760 and found no blocking correctness, security, data-loss, authorization, or severe compatibility issues. The new .tool-versions placeholders match the existing VitePress replacement logic and .tool-versions keys. I left one non-blocking docs navigation question inline.
ChristianPavilonis
approved these changes
Jun 8, 2026
prk-Jr
added a commit
that referenced
this pull request
Jun 17, 2026
Brings PR15's main-merge progress (multi-backend asset proxy, S3 SigV4 signing, image optimizer primitive, DataDome server-side, settings/docs) up into the PR16 axum dev-server branch. Conflict resolutions: - fastly/app.rs: keep captured tls_protocol/tls_cipher (PR16) plus ..ClientInfo::default() for PR15's new device-signal fields; single publisher import incl. buffer_publisher_response + BoundedWriter. - fastly/main.rs: keep both the trusted x-ts-tls-* header injection (PR16) and derive_device_signals (PR15); drop the now-orphaned fastly-local resolve_publisher_response_buffered in favor of core buffer_publisher_response. - core/proxy.rs: keep PR16's origin_response_metadata/ apply_image_passthrough_metadata helper refactor (superset of PR15's inline image/pixel logic) and restore PR15 #754 IMAGE_FALLBACK_CONTENT_TYPE; union imports; web_time for EC clock, std SystemTime only at the chrono-bound s3 sign_headers call. - core/publisher.rs: dedupe the doubly-merged BoundedWriter, keeping the pub version the adapters import. - core/platform/test_support.rs: merge both StubHttpClient field sets (concurrent_fanout + image-optimizer/stream/method/uri stubs). - core/Cargo.toml: restore the wasm32-unknown-unknown uuid/getrandom js block the auto-merge dropped (required for the Cloudflare build). - axum/cloudflare platform.rs: ..ClientInfo::default() and PlatformBackendSpec.host_header_override for the new fields. - migration_guards.rs: ec/kv.rs and ec/rate_limiter.rs are now fully Fastly-free (required for the wasm32-unknown-unknown core build), so move them into checked_sources and drop the obsolete deferred-EC allowlist. - docs/getting-started.md: template version vars (PR15 #760) + Fastly-optional framing (PR16 axum dev server).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #747. Supersedes #758.
Problem
The Getting Started prerequisites listed Rust with a hardcoded version and omitted Node.js/npm entirely. Contributors without Node installed hit a confusing
build.rsfailure when the JS build runs duringcargo build.Approach
Rather than hardcode versions (which drift from the source of truth), this uses the version-substitution mechanism already present in
docs/.vitepress/config.mts, which parses.tool-versionsand replaces{{TOOL_VERSION}}placeholders at markdown-parse time.Changes
docs/guide/getting-started.md{{RUST_VERSION}},{{NODEJS_VERSION}}, and{{FASTLY_VERSION}}; adds NodeJS as an explicit prerequisiteRenders as:
Versions now stay in sync with
.tool-versionsautomatically — no future doc edits needed when toolchain versions bump.Test plan
cd docs && npm run build— substitution renders real versions indist/guide/getting-started.htmlcd docs && npm run format— passes