Skip to content

fix: move test structures that fail CI - #320

Merged
FelixBaensch merged 1 commit into
devfrom
move-test-structures
Nov 10, 2026
Merged

FelixBaensch merged 1 commit into
devfrom
move-test-structures

Conversation

@JanCBrammer

Copy link
Copy Markdown
Collaborator

This PR addresses #317.

Moving two test structures that didn't contribute to the regression or invariance tests since they didn't produce an InChI. Moving each structure to a dedicated unit test instead.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues were identified in the added error-case tests or the CI regression configuration adjustment.

No open issues 🎉

What changed in this PR

This PR supports #317 by adding dedicated unit tests for two structures that do not produce InChIs and adjusting the CI regression configuration.

Changes:

  • Adds a hydrogen-isotope rejection test for the iso-H-Bridge structure.
  • Adds a canonicalization-error test for PUBCHEM_COMPOUND_CID-102182973.
  • Removes that PubChem identifier from the CI regression configuration set.
File Description
INCHI-1-TEST/​tests/​test_unit/​test_isotope_error.cpp Checks the error status, empty InChI output, and diagnostic for an unsupported hydrogen isotope.
INCHI-1-TEST/​tests/​test_unit/​test_canonicalization_error.cpp Checks the error status, empty InChI output, and canonicalization diagnostic for the PubChem structure.
INCHI-1-TEST/​tests/​test_library/​config/​config_ci.py Removes the PubChem identifier from the regression configuration set.

Review effort: Balanced

@github-actions

Copy link
Copy Markdown

Unit Test Coverage Report

Coverage Regression Summary

Metric PR (%) Base (%) Difference (pp)
Lines 36.5 34.3 +2.20
Branches 24.0 22.3 +1.70

Find details on the base coverage at https://iupac-inchi.github.io/InChI/coverage/index.html

Find details on this PR's coverage by downloading coverage-reports-42830202603 and opening html/index.html

@FelixBaensch
FelixBaensch merged commit 7f26903 into dev Nov 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move structures that don't produce InChIs from CI testset to unit tests

3 participants