Repository navigation
fix: move test structures that fail CI - #320
Merged
Merged
Conversation
Moving two test structures that didn't contribute to the regression or invariance tests since they didn't produce an InChI. Moving each structure to a dedicated unit test instead.
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified in the added error-case tests or the CI regression configuration adjustment.
No open issues 🎉
What changed in this PR
This PR supports #317 by adding dedicated unit tests for two structures that do not produce InChIs and adjusting the CI regression configuration.
Changes:
- Adds a hydrogen-isotope rejection test for the
iso-H-Bridgestructure. - Adds a canonicalization-error test for
PUBCHEM_COMPOUND_CID-102182973. - Removes that PubChem identifier from the CI regression configuration set.
| File | Description |
|---|---|
INCHI-1-TEST/tests/test_unit/test_isotope_error.cpp |
Checks the error status, empty InChI output, and diagnostic for an unsupported hydrogen isotope. |
INCHI-1-TEST/tests/test_unit/test_canonicalization_error.cpp |
Checks the error status, empty InChI output, and canonicalization diagnostic for the PubChem structure. |
INCHI-1-TEST/tests/test_library/config/config_ci.py |
Removes the PubChem identifier from the regression configuration set. |
Review effort: Balanced
Unit Test Coverage ReportCoverage Regression Summary
Find details on the base coverage at https://iupac-inchi.github.io/InChI/coverage/index.html Find details on this PR's coverage by downloading coverage-reports-42830202603 and opening html/index.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #317.