Icinga DB: Fix inconsistent state_type for volatile checks - #10970
Open
Akulbanxal wants to merge 2 commits into
Open
Icinga DB: Fix inconsistent state_type for volatile checks#10970Akulbanxal wants to merge 2 commits into
Akulbanxal wants to merge 2 commits into
Conversation
When a checkable is configured as volatile, every state change is treated as hard. However, its internal state type in the core remains soft. This change ensures that the serialized state_type in Icinga DB's runtime state is set to hard for volatile checkables in a non-OK state, matching the history stream behavior. refs Icinga#10879
yhabteab
reviewed
Aug 27, 2026
| StateType stateType; | ||
|
|
||
| if (checkable->HasBeenChecked()) { | ||
| if (checkable->GetVolatile() && !checkable->IsStateOK(checkable->GetStateRaw())) { |
Member
There was a problem hiding this comment.
Actually, you can even remove the the second condition and just set it to hard state as there is no soft OK state changes, i.e., just the volatile check should suffice. Otherwise, looks fine to me. Please also rebase against the latest master to make the CI happy.
yhabteab
added
the
consider backporting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a checkable is configured as volatile, every state change is treated as hard. However, its internal state type in the core remains soft. This change ensures that the serialized state_type in Icinga DB's runtime state is set to hard for volatile checkables in a non-OK state, matching the history stream behavior.
fixes #10879