Skip to content

Fix use of wrong log function on heartbeat loss - #372

Merged
julianbrost merged 1 commit into
masterfrom
bugfix/heartbeat-loss-log-func
Sep 23, 2021
Merged

julianbrost merged 1 commit into
masterfrom
bugfix/heartbeat-loss-log-func

Conversation

@julianbrost

Copy link
Copy Markdown
Member

Has to use the Warnw function as it passes additional zap attributes.

Before

2021-09-23T09:16:33.902+0200	WARN	icingaredis/heartbeat.go:149	Lost Icinga 2 heartbeat{timeout 8 60000000000  <nil>}

After

2021-09-23T09:29:30.913+0200	WARN	icingaredis/heartbeat.go:149	Lost Icinga 2 heartbeat	{"timeout": "1m0s"}

Has to use the Warnw function as it passes additional zap attributes.
@cla-bot cla-bot Bot added the cla/signed label Sep 23, 2021
@julianbrost julianbrost added the bug Something isn't working label Sep 23, 2021
@lippserd
lippserd self-requested a review September 23, 2021 07:34
@julianbrost
julianbrost merged commit 6bc965a into master Sep 23, 2021
@julianbrost
julianbrost deleted the bugfix/heartbeat-loss-log-func branch September 23, 2021 08:53
@lippserd lippserd added this to the v1.0.0-rc2 milestone Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cla/signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants