Skip to content

Delete config.yml.example - #375

Closed
Al2Klimov wants to merge 1 commit into
masterfrom
Al2Klimov-patch-1
Closed

Al2Klimov wants to merge 1 commit into
masterfrom
Al2Klimov-patch-1

Conversation

@Al2Klimov

Copy link
Copy Markdown
Member

No description provided.

@Al2Klimov
Al2Klimov requested a review from lippserd September 28, 2021 10:12
@cla-bot cla-bot Bot added the cla/signed label Sep 28, 2021
@Al2Klimov Al2Klimov mentioned this pull request Sep 28, 2021
1 task done
@lippserd lippserd added this to the v1.0.0-rc2 milestone Sep 28, 2021

@julianbrost julianbrost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@Al2Klimov

Copy link
Copy Markdown
Member Author

#366 (comment)

@julianbrost

Copy link
Copy Markdown
Member

That comment gives no reasoning at all.

@lippserd

Copy link
Copy Markdown
Member

That comment gives no reasoning at all.

That file was only used for packaging but we (should) no longer depend on it. (Same for the systemd service file.)

@julianbrost

Copy link
Copy Markdown
Member

The systemd service file got removed in #345 and unfortunately, that PR doesn't provide any reasoning either. I can't remember the reason and can't reconstruct it either. One thing I could have imagined that the service file differs between distributions but not even that's the case right now.

Anyways, I think the example config in the source repo is quite helpful to get people started working on the code. To get Icinga DB running, you need a config file (you can do without a systemd service file, that's why it's valid to make a difference between the two in my opinion), so it's handy to be able to just copy it over.

@lippserd lippserd removed this from the v1.0.0-rc2 milestone Sep 28, 2021
@lippserd

Copy link
Copy Markdown
Member

Let's keep it.

@lippserd lippserd closed this Sep 28, 2021
@lippserd
lippserd deleted the Al2Klimov-patch-1 branch May 4, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants