Skip to content

knowledge: distill vllm-metal with portable AREX workflow #218

Closed

Description

@david6666666

Accepted goal and delegation

The user requested sequential issue → linked PR → independent review/checks → normal merge for vllm-project/vllm-metal, then three separately selected Metal inference repositories. The user subsequently excluded h3-metal on 2026-10-28; no h3-metal work is included. This issue owns only the first repository. Accountable parent: Codex distill_metal_engine_batch; implementer: Codex author_metal_knowledge (actual gpt-6.1-sol, xhigh). The user authorized source/CPU-supported candidate knowledge delivery and merge with native verification gaps preserved. Closure owner: accountable authorized parent/integrator after acceptance summary.

Source and method

Source: https://github.com/vllm-project/vllm-metal/tree/e7df7a6ff215f99c7842552d230fdbc709835934 (cloned current head; package 0.32.0).
Method: AREX-Skill portable create/prepare/workflow/verify, pinned ac3fe1afa80fb9a09775ecfb2b6cc3ba850a2db6. InferRSI repository integration, not managed DisCo installation or DisCo CLI/model API execution.

Bounded delivery

Three routes: platform/config/native ABI preparation; paged KV/cache/offload/request lifetime; qualification/speculative decoding and measurement boundaries. Include pinned code/document/test readsets, licenses/notices, self-contained bounded offline helpers, difficult assertion-backed cases, honest source/CPU/native reports, registered discovery and both maintained matrices. Other upstream features receive explicit coverage/gap classification rather than implied full-engine qualification.

Acceptance criteria

  • Exact source readset hashes and license resolution/gate.
  • Integrated root plus three complete English sub-skills, references, troubleshooting, safe helpers and difficult cases.
  • Native candidate/backend map before drafting; safe CPU source tests only after graph integration; Apple MLX/Metal/model tests explicitly BLOCKED_REQUIRED_BACKEND.
  • Catalog/index AND coverage regenerated from published source revision; owners/matrices consistent; noneditable-wheel reads and full pytest/ruff.
  • Stable-head independent review and exact-current-head Ready CI/admission before authorized squash merge; acceptance summary before closure.

Non-goals / limits

No engine changes, upstream writes, model/weight downloads, paid provider calls, GPU jobs, public service launches or system/toolchain installs. No performance/quality/serving PASS: source-derived candidate remains empirical not_run and Apple native-unverified. No unrelated PR #209/#210 acceptance, no rule/workflow rewrite or policy bypass.

Accepted delivery

PR #219 merged normally as d9dc091e255acefef731249aa2e50dcc9118d69f. The acceptance card records actual checks, independent review, current-base evidence and preserved native gaps. Scope accepted as a source/CPU candidate, not native engine qualification.

Activity

  1. david6666666 commented on Oct 28, 2026

    @david6666666
    CollaboratorAuthor

    Accepted: vLLM Metal source/CPU candidate knowledge

    flowchart LR
      A["Pinned vllm-metal + AREX sources"] --> B["Platform, cache and qualification graph"]
      B --> C["Packaged discovery and both matrices"]
      C --> D["Reviewed source/CPU candidate accepted"]
      B -.-> E["Apple native/model/service gaps retained"]
    
    Loading
    • Delivered: PR #219, normally squash-merged as d9dc091e255acefef731249aa2e50dcc9118d69f: English root + 3 routes,38-file readset, 3 offline helpers, 10 assertion cases and retained Apache-2.0 notice. 68 registered roots / 104 skill documents / 116 catalog records; index and coverage refreshed.
    • Verified: selected original pure source tests 58 passed; corrected-head local serial suite 1540 passed / 10 skipped / 154 subtests plus Ruff/generators/license/wheel. Ready477 all 4 Python 3.10 / 3.11 full/installed jobs succeeded on current-base merge09b1fb3; its 3.10 suite 1591 passed / 11 skipped / 183 subtests is a distinct newer-base scope. Independent exact-head read-only review has no open findings; latest premerge admission succeeded.
    • Limits: candidate/partial_cpu_only, not engine or campaign PASS. Required Apple MLX/Metal/MPS/model, native transfer/sleep-wake/dispatch/parity, quality/service/performance and broad skill efficacy remain unverified/BLOCKED_REQUIRED_BACKEND. Inspection-environment pip check failed; NO_LICENSE is the actual unauthenticated resolver fallback, not legal absence. No models/GPU/paid/service/toolchain execution.
    Full acceptance record

    Source e7df7a6ff215f99c7842552d230fdbc709835934 (0.32.0); method ac3fe1afa80fb9a09775ecfb2b6cc3ba850a2db6. Reviewed head 1a23a54d2ae8272bdc10eb772fd197460ad7dc00; assessed main 57f47bea46f2048321907bd6b192683e3e636311; hosted tested merge 09b1fb3694ab8dac4597794bb536963d2988d19a. Source subtree is byte-identical between reviewed head and tested merge; main's unrelated policy/SkillEval changes were preserved, not accepted or reopened by this issue.

    Final noneditable wheel SHA256 f8acadff59f5c65fb064340e51755941829553d06ac8e5a4c0773e1356101636; all 23 owner resources match. Existing DCO and both actual material-author trailers retained. Latest premerge policy run 40676108682 SUCCESS. Initial formatting/candidate-count failures, isolated digest rerun and final serial correction are retained in PR history; no baseline/root-cause excuse invented.

    Authorized parent/coordinator accepted this bounded repository delivery and closure after independent review/checks. This is portable AREX-informed InferRSI integration, not DisCo CLI/model execution or managed import. h3-metal was canceled and has no delivery. Remaining selected repositories require their own sequential issues/PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions