feat: add pam agent - #351
Conversation
|
💬 Discussion in Slack: #pr-review-cli-351-feat-add-pam-agent Posted by Review Police — reviews, comments, new commits, and CI failures will stream into this channel. |
PR overviewAll previously flagged issues have been addressed. No open security concerns remain on this pull request. Security reviewNo open security issues remain on this pull request. Fixed/addressed: 9 · PR risk: 0/10 |
|
| Filename | Overview |
|---|---|
| packages/pam/agent/proxy.go | Adds the generic lazy PAM relay, but exposes privileged sessions to unauthenticated local clients and prematurely closes half-closed streams. |
| packages/pam/agent/adapters.go | Adds agent-specific instruction delivery, but rewrites project-controlled context paths without symlink protection. |
| packages/pam/agent/session.go | Implements serialized lazy session creation, reference tracking, retirement, and bounded termination draining. |
| packages/pam/agent/run.go | Coordinates preflight, proxy startup, environment generation, child execution, logging, and concurrent cleanup. |
| packages/pam/agent/manifest.go | Defines strict YAML decoding and validates account paths, durations, ports, duplicates, and instruction size. |
| packages/pam/agent/preflight.go | Resolves manifest entries against paginated accessible accounts and validates launch, approval, reason, and account-type requirements. |
| packages/pam/local/base-proxy.go | Generalizes relay and gateway dialing around explicit live sessions while preserving static interactive-proxy behavior. |
| packages/cmd/pam.go | Wires the new agent command, validates its argument split, resolves credentials, and propagates the child exit status. |
| packages/api/api.go | Adds the paginated accessible PAM accounts API call using the configured backend URL. |
| packages/api/model.go | Adds typed account-listing response models used during preflight. |
Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'origin/mai..." | Re-trigger Greptile
Description 📣
This PR adds support for PAM agent usage
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets