chore: invoke migrated Jobs via the -i/-o short options - #27
Merged
Conversation
Seven Jobs call scripts that now build their I/O options from
rdkit_utils.add_common_molecule_io_args(). Those scripts accept
-i/--infile/--input and -o/--outfile/--output; the long --input and
--output spellings are deprecated aliases that will be withdrawn.
Switch the affected command blocks to the -i/-o short forms rather than
the canonical long spellings. The short forms are canonical too, and they
are the only spelling that works against every image these Jobs can be
loaded against: informaticsmatters/vs-prep:stable — the tag all of these
Jobs pin — was last published in June 2024 and predates the migration, so
it has no --infile/--outfile at all. Writing --infile here would make the
definitions unloadable until a new image ships; -i/-o has no such ordering
dependency and survives the alias removal unchanged.
This also matches how squonk2-desc-mordred, squonk2-desc-rdkit and
squonk2-train-test-split already invoke their migrated scripts.
Job Definition versions are bumped, per docs/versioning.md.
Verified with jote against the main manifest:
- published vs-prep:stable ..... found=32 passed=32 failed=0
- locally built :latest ........ found=11 passed=11 failed=0
(the 7 changed Jobs, via --image-tag latest)
Commands for scripts that never adopted the shared group are untouched:
max_min_picker, le_conformers_for_mol, reactor, sucos, fail,
prepare_rdock, pharmacophore, convert_file, sdf_manip and the moldb
modules all declare --input/--output themselves. The --input/--output on
the two nextflow Jobs are workflow params, not script options.
Refs InformaticsMatters/squonk2-jobs#39
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Aug 11, 2026
This was referenced Aug 11, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the Job Definition half of InformaticsMatters/squonk2-jobs#39.
What changed
Seven Jobs invoke scripts that now build their I/O options from
rdkit_utils.add_common_molecule_io_args(). Their command blocks moved from--input/--outputto-i/-o, and their Job Definition versions arebumped per
docs/versioning.md.rdkit.yamlgenerate-low-energy-conformersle_conformers.pyrdkit.yamlrdkit-molpropsrdkit_props.pyrdkit.yamlrdkit-deduprdkit_dedup.pyrdkit.yamlsa-scoresa_score.pyrdkit.yamlsimilarity-screen-rdkitscreen.pyrdkit.yamlcluster-butinacluster_butina.pyim-virtual-screening.yamlenumerate-candidatesenumerate.pyWhy the short forms, not
--infile/--outfileIssue #39 asked for the canonical long spellings. I tried that first and
jotefailed 11 of 32 tests:Every Job in this manifest pins
tag: 'stable', andinformaticsmatters/vs-prep:stablewas last published on 2024-06-10 — longbefore the migration. It has no
--infile/--outfileat all. So a definitionwritten with the long spellings cannot be loaded until a new image is published,
which turns a cosmetic change into a release-ordering problem.
-iand-oare canonical too, and they are the only spelling that worksagainst both the pre-migration image and the migrated code — and they survive
the eventual removal of the
--input/--outputaliases without a second pass.They are also already how
squonk2-desc-mordred,squonk2-desc-rdkitandsquonk2-train-test-splitinvoke their migrated scripts.Verification
jote -m data-manager/manifest-im-virtual-screening.yaml, nextflow 22.10.0 tomatch
Dockerfile-nextflow:vs-prep:stable—found=32 passed=32 failed=0:latestcarrying the migrated scripts, for the 7changed Jobs via
--image-tag latest—found=11 passed=11 failed=0The second run is the first time
jotehas exercised the migratedvirtual-screening scripts: the earlier post-migration run passed entirely on the
published 2024 image, so it validated the old code.
Deliberately unchanged
max_min_picker,le_conformers_for_mol,reactor,sucos,fail,prepare_rdock,pharmacophore,convert_file,sdf_manipand themoldbmodules declare
--input/--outputthemselves and never adopted the sharedgroup — renaming them would be a gratuitous breaking change. The
--input/--outputon the two nextflow Jobs areparams.input/params.outputfor
le_conformers.nfandenumerate.nf; both workflows already call theirscripts with
-i/-o.cluster-butina's--output-fragmentis its own flag.Note that #39's scope table mislabels
rdkit.yamllines 1631–1632 ascluster_butina.py; that command ispython -m sdf_manip, which is out ofscope. The real scope was 7 Jobs, not 8.
🤖 Generated with Claude Code