fix: move similarity-screen-rdkit 'derived-from' to annotation-properties - #30
Merged
Merged
Conversation
…ties
'derived-from' was nested one level too deep, inside 'fields-descriptor',
rather than sitting alongside it under 'annotation-properties'. The other
eight occurrences in this file are placed correctly; this one is an
indentation slip.
It went unnoticed because 'annotation-properties' was declared
'additionalProperties: true' in the Job Definition schema, so the whole
block was free-form and any key validated. im-data-manager-job-decoder
2.7.0 (released 2026-08-13) models the block properly, and the misplaced
key now fails validation:
! Job definition "data-manager/rdkit.yaml" does not comply with schema
Additional properties are not allowed ('derived-from' was unexpected)
'derived-from' is legitimate and supported - it is a first-class property
of the new 'annotation-properties' definition. Only its placement was
wrong.
This is not purely cosmetic: the output has been emitting a
'fields-descriptor' carrying a stray key and no 'derived-from' annotation
at all. Fixing the placement changes the annotation the Data Manager
receives, so the Job version is bumped 1.0.1 -> 1.0.2.
Verified with jote 0.13.0 against decoder 2.7.0 - all six manifests pass
'jote --dry-run' (32/32 for manifest-im-virtual-screening.yaml).
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Aug 13, 2026
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What broke
im-data-manager-job-decoder2.7.0 was released on 2026-08-13 and immediatelyturned CI red in the
squonk2-jobs umbrella repo:
It is a real bug, not a schema regression
derived-fromis legitimate and supported — 2.7.0 makes it a first-classproperty of the new
annotation-propertiesdefinition. Only its placement herewas wrong. In
similarity-screen-rdkitit sits one level too deep, insidefields-descriptor:An indentation slip — 16 spaces where 14 were meant. The other eight occurrences
in this file are correct, which makes the intent unambiguous.
It survived because
annotation-propertieswas declaredadditionalProperties: true, so the block was free-form and any key validated.2.7.0 models it properly and the slip surfaced. This is exactly the class of hole
docs/schema-coverage.mddescribes, and closing it found a genuine latent defect first time out.
Why the version bump
Not purely cosmetic. This output has been shipping a
fields-descriptorcarryinga stray key and no
derived-fromannotation at all. Fixing the placementchanges the annotation the Data Manager actually receives, so
similarity-screen-rdkitgoes1.0.1→1.0.2perthe versioning rules.
Verification
Reproduced CI exactly — jote 0.13.0 resolving decoder 2.7.0:
manifest-im-virtual-screening.yamlmanifest-moldb.yamlmanifest-fragnet-search.yamlmanifest-im-mordred.yamlmanifest-dmpk.yamlmanifest-silicos-it.yamlBefore the fix,
manifest-im-virtual-screening.yamlfailed; all six now pass.I also validated every Job Definition across all ten Job repositories against
the 2.7.0 schema: this was the only violation in the ecosystem, so no other
repository needs changing.
Related
A companion PR in
squonk2-jobspins the decoder in CI. The umbrella workflowpins
JOTE_VERSIONbut jote declaresim-data-manager-job-decoder>=2.6.1with noupper bound — the schemas live in the decoder, so they float, and a decoder
release lands as a failure on whatever unrelated PR comes next.
🤖 Generated with Claude Code