This repository was archived by the owner on Jul 13, 2026. It is now read-only.
Better Optimizer - #147
Merged
Merged
Conversation
dxoigmn
marked this pull request as ready for review
May 16, 2023 18:17
This reverts commit 41eb387.
15 tasks
dxoigmn
marked this pull request as draft
May 16, 2023 20:03
dxoigmn
marked this pull request as ready for review
May 16, 2023 20:06
dxoigmn
marked this pull request as draft
May 17, 2023 18:28
dxoigmn
marked this pull request as ready for review
May 17, 2023 18:28
mzweilin
suggested changes
Jun 1, 2023
mzweilin
left a comment
mzweilin
left a comment
Contributor
There was a problem hiding this comment.
I like the change! Maybe we can further simplify the config.
| self.perturber = perturber | ||
| self.composer = composer | ||
| self.optimizer_fn = optimizer | ||
| if not isinstance(self.optimizer_fn, OptimizerFactory): |
Contributor
There was a problem hiding this comment.
Shall we add this to mart/models/modular.py so that we can simplify the config in mart/configs/optimizer? That will make it easier to add other off-the-shelf optimizers from PyTorch.
Member
Author
There was a problem hiding this comment.
Perhaps. But I think that should live in another PR.
14 tasks
…r` (and `Adversary`) (#152) * Simplify optimizer configs by hiding OptimizerFactory in LitModular abd Adversary. * Add simplified config in comment/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR removes attack-specific optimizers and moves them to be generic PL optimizers.
Depends upon #146.
Type of change
Please check all relevant options.
Testing
Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.
Before submitting
pre-commit run -acommand without errorsDid you have fun?
Make sure you had fun coding 🙃