Skip to content
This repository was archived by the owner on Jul 13, 2026. It is now read-only.

Allow LitModular.*_step_log to be a dictionary - #168

Merged
dxoigmn merged 7 commits into
mainfrom
better_litmodular
Jun 22, 2023
Merged

Allow LitModular.*_step_log to be a dictionary#168
dxoigmn merged 7 commits into
mainfrom
better_litmodular

Conversation

@dxoigmn

@dxoigmn dxoigmn commented Jun 13, 2023

Copy link
Copy Markdown
Member

What does this PR do?

LitModular.*_step_log currently takes a list of things to log. However, it is always better to consume a dict due to Hydra's limitation when composing lists. This PR changes LitModular to accept a dict. Because it now consumes a dict, this also enables users to rename values (instead of using ReturnKwargs to do this).

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • pytest
  • CUDA_VISIBLE_DEVICES=0 python -m mart experiment=CIFAR10_CNN_Adv trainer=gpu trainer.precision=16 reports 70% (21 sec/epoch).
  • CUDA_VISIBLE_DEVICES=0,1 python -m mart experiment=CIFAR10_CNN_Adv trainer=ddp trainer.precision=16 trainer.devices=2 model.optimizer.lr=0.2 trainer.max_steps=2925 datamodule.ims_per_batch=256 datamodule.world_size=2 reports 70% (14 sec/epoch).

Before submitting

  • The title is self-explanatory and the description concisely explains the PR
  • My PR does only one thing, instead of bundling different changes together
  • I list all the breaking changes introduced by this pull request
  • I have commented my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

@dxoigmn dxoigmn changed the title Allow *_step_log to take dict Allow LitModular.*_step_log to be a dictionary Jun 13, 2023
@dxoigmn
dxoigmn requested a review from mzweilin June 13, 2023 21:29
@dxoigmn
dxoigmn marked this pull request as ready for review June 14, 2023 01:07

@mzweilin mzweilin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dxoigmn
dxoigmn merged commit 44737fa into main Jun 22, 2023
@dxoigmn
dxoigmn deleted the better_litmodular branch June 22, 2023 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants