Skip to content
This repository was archived by the owner on Jul 13, 2026. It is now read-only.

Enable overriding of special args in SequentialDict.forward - #175

Merged
dxoigmn merged 24 commits into
mainfrom
better_sequentialdict3
Jun 28, 2023
Merged

Enable overriding of special args in SequentialDict.forward#175
dxoigmn merged 24 commits into
mainfrom
better_sequentialdict3

Conversation

@dxoigmn

@dxoigmn dxoigmn commented Jun 15, 2023

Copy link
Copy Markdown
Member

What does this PR do?

SequentialDict uses CallWith to manage how to call a underlying nn.Module and handle that nn.Module's output. All of this is handled at instantiation time. This PR adds the ability to override this functionality at execution time by adding those same special args to CallWith.forward.

Type of change

Please check all relevant options.

  • Improvement (non-breaking)
  • Bug fix (non-breaking)
  • New feature (non-breaking)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing

Please describe the tests that you ran to verify your changes. Consider listing any relevant details of your test configuration.

  • pytest
  • CUDA_VISIBLE_DEVICES=0 python -m mart experiment=CIFAR10_CNN_Adv trainer=gpu trainer.precision=16 reports 70% (21 sec/epoch).
  • CUDA_VISIBLE_DEVICES=0,1 python -m mart experiment=CIFAR10_CNN_Adv trainer=ddp trainer.precision=16 trainer.devices=2 model.optimizer.lr=0.2 trainer.max_steps=2925 datamodule.ims_per_batch=256 datamodule.world_size=2 reports 70% (14 sec/epoch).

Before submitting

  • The title is self-explanatory and the description concisely explains the PR
  • My PR does only one thing, instead of bundling different changes together
  • I list all the breaking changes introduced by this pull request
  • I have commented my code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have run pre-commit hooks with pre-commit run -a command without errors

Did you have fun?

Make sure you had fun coding 🙃

@dxoigmn dxoigmn changed the title Better sequentialdict3 Enable overriding of special args in SequentialDict.forward Jun 15, 2023
@dxoigmn
dxoigmn requested a review from mzweilin June 15, 2023 19:23
@dxoigmn
dxoigmn marked this pull request as ready for review June 15, 2023 19:23
This was referenced Jun 15, 2023
Comment thread mart/nn/nn.py Outdated
Comment thread mart/nn/nn.py Outdated
@dxoigmn

dxoigmn commented Jun 23, 2023

Copy link
Copy Markdown
Member Author

robustbench tests still failing but this is ready for review @mzweilin

@dxoigmn
dxoigmn requested review from mzweilin and removed request for mzweilin June 23, 2023 21:27

@mzweilin mzweilin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dxoigmn
dxoigmn merged commit 60fc689 into main Jun 28, 2023
@dxoigmn
dxoigmn deleted the better_sequentialdict3 branch June 28, 2023 15:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants