Move test utils out of split-patch/ to test/ subdir - #25
Merged
Conversation
- Set `OUR_CARGO_BUILD_FLAGS` for miri_run make target - Rename split-patch path in `ci-make` script
Since it's not easy to switch there, and seeing all output could be useful. Searching for ": Err" via the browser should be easy enough?
yusufraji
approved these changes
Aug 18, 2026
yusufraji
left a comment
yusufraji
left a comment
Collaborator
There was a problem hiding this comment.
make ci output looks cleaner now, with lower verbosity. Looks good. 🚀
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is on top of #24 (only the last 3 commits are new).
Some files from the original test/ directory are not specific to split-patch/. Move them to test/, also, this allows to make a new testing crate for that purpose, partially solving the issue with the
[[bin]]programs. (BTW, an idea to try for the other program,split-patch/test/test-split-patches-in-dir.rs, might be to move it to split-patch/tests/ and see if it can be built for normal execution somehow.)Also, while at it, make
make cisilent about targets that do not fail; this makes it nice to use interactively. Re-add a target that always shows the output for the actual CI.